[SERVE-657] Replace special characters by underscore to fix logging failure during serve.deploy() #52576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrarsheikh
requested changes
Apr 24, 2025
Comment on lines
+572
to
+573
| component_name = re.sub(FILE_NAME_REGEX, '_', component_name) | ||
| component_id = re.sub(FILE_NAME_REGEX, '_', component_id) |
There was a problem hiding this comment.
@zcin, does this have any side effects on the service's ability to reference the correct app log on anyscale ?
Is component_id user-provided? If not, maybe we can avoid applying the sub-operation on it.
There was a problem hiding this comment.
Hmm yeah I don't know the full implications of this, I would be hesitant to do this unless it's fully scoped out what the effects are.
@GeneDer might know more about the logging issue specifically.
There was a problem hiding this comment.
another way is to just provide some useful log statements to users that include WARN or something.
ok-scale
force-pushed
the
SERVE-657-update-naming
branch
from
051a78a to
d8c9481
Compare
Signed-off-by: Omkar Kulkarni <omkar@omkar-JKJHCX74L6.local>
ok-scale
force-pushed
the
SERVE-657-update-naming
branch
from
0ed794b to
5cda7d3
Compare
Signed-off-by: Omkar Kulkarni <omkar@omkar-JKJHCX74L6.local>
Signed-off-by: Omkar Kulkarni <omkar@omkar-JKJHCX74L6.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When creating a Serve deployment with a name containing a slash (such as
TextGenerationModel.options(name="huawei-noah/TinyBERT_General_4L_312D")) leads to actor failures. The error occurs because the slash in the name is likely being used as a path separator in log files.Error:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/ray/session_2025-03-11_16-02-48_264712_45753/logs/serve/replica_default_huawei-noah/TinyBERT_General_4L_312D_eo3vqu7d.log'In general, any other special character used may cause the logger to crash. This branch fixes the issue by replacing all special characters with
_for logging purposes.Related issue number
https://anyscale1.atlassian.net/browse/SERVE-657
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.