Skip to content

fix: wrong types definition specified for class field #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: wrong types definition specified for class field #415

wants to merge 1 commit into from

Conversation

OutdatedGuy
Copy link

According to official docs for customer creation using razorpay API, fail_existing should be a string.

But the types defined were boolean, numeric 1 & 0.

fixes #377, fixes #381

@OutdatedGuy
Copy link
Author

@ankitdas13 can you look into this?

@OutdatedGuy
fix: wrong types definition specified for class field
aed54a3 
According to [official docs for customer creation](https://razorpay.com/docs/api/customers/create/) using razorpay API, `fail_existing` should be a string.

But the types defined where `boolean`, numeric `1` & `0`.

fixes razorpay#377, fixes razorpay#381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@roopamparadkar roopamparadkar roopamparadkar approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with create customer when customer is already exist and fail_existing value is 0 Customer Already exists error
2 participants
@OutdatedGuy @roopamparadkar