Skip to content

Honor $JAVA_HOME in require_java #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

Honor $JAVA_HOME in require_java #2523

merged 2 commits into from
Apr 18, 2025

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Apr 18, 2025

JRuby does not require $JAVA_HOME/bin to be part of $PATH, therefore we should test java version with $JAVA_HOME/bin/java -version when $JAVA_HOME is defined.

See: ruby/ruby-builder#22 (comment)

@ntkme ntkme mentioned this pull request Apr 18, 2025
Merged
eregon
eregon approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ntkme
Copy link
Contributor Author

ntkme commented Apr 18, 2025

Pushed a commit to unset $JAVA_HOME before running test so that the existing tests are not affected by $JAVA_HOME which is set by default in GitHub Actions.

@eregon eregon merged commit f5b18da into rbenv:master Apr 18, 2025
4 checks passed
@ntkme ntkme deleted the java-home branch April 18, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntkme @eregon