refactor: Simplify authorize and authorizeOrNotFound functions by removing message parameter

Author: rcalicdan

src/Helpers/authorization_helper.php

@@ -56,15 +56,10 @@ function cannot($ability, ...$arguments)
  * @throws UnauthorizedPageException If the user is not authorized.
  */
 if (! function_exists('authorize')) {
-    function authorize($ability, $message = 'Unauthorized Action.', ...$arguments): bool
+    function authorize($ability, ...$arguments): bool
     {
-        if (! is_string($message)) {
-            array_unshift($arguments, $message);
-            $message = 'Unauthorized Action.';
-        }
-
         if (cannot($ability, ...$arguments)) {
-            throw new UnauthorizedPageException($message);
+            throw new UnauthorizedPageException('Unauthorized Action.');
         }
 
         return true;
@@ -83,15 +78,10 @@ function authorize($ability, $message = 'Unauthorized Action.', ...$arguments):
  * @throws PageNotFoundException If the user is not authorized.
  */
 if (! function_exists('authorizeOrNotFound')) {
-    function authorizeOrNotFound($ability, $message = 'Page Not Found.', ...$arguments): bool
+    function authorizeOrNotFound($ability, ...$arguments): bool
     {
-        if (! is_string($message)) {
-            array_unshift($arguments, $message);
-            $message = 'Page Not Found.';
-        }
-
         if (cannot($ability, ...$arguments)) {
-            throw PageNotFoundException::forPageNotFound($message);
+            throw PageNotFoundException::forPageNotFound('Page Not Found.');
         }
 
         return true;

src/Traits/AuthorizationTrait.php

@@ -53,15 +53,10 @@ protected function cannot($ability, ...$arguments)
      *
      * @throws UnauthorizedPageException If the user is not authorized.
      */
-    protected function authorize($ability, $message = 'Unauthorized Action.', ...$arguments): bool
+    protected function authorize($ability, ...$arguments): bool
     {
-        if (! is_string($message)) {
-            array_unshift($arguments, $message);
-            $message = 'Unauthorized Action.';
-        }
-
         if (cannot($ability, ...$arguments)) {
-            throw new UnauthorizedPageException($message);
+            throw new UnauthorizedPageException('Unauthorized Action.');
         }
 
         return true;
@@ -78,15 +73,10 @@ protected function authorize($ability, $message = 'Unauthorized Action.', ...$ar
      *
      * @throws PageNotFoundException If the user is not authorized.
      */
-    public function authorizeOrNotFound($ability, $message = 'Page Not Found.', ...$arguments): bool
+    public function authorizeOrNotFound($ability, ...$arguments): bool
     {
-        if (! is_string($message)) {
-            array_unshift($arguments, $message);
-            $message = 'Page Not Found.';
-        }
-
         if (cannot($ability, ...$arguments)) {
-            throw PageNotFoundException::forPageNotFound($message);
+            throw PageNotFoundException::forPageNotFound('Page Not Found.');
         }
 
         return true;