Skip to content

Commit 8e4c8f9

Browse files
authored
test: fix test case (#383)
1 parent 4adfc91 commit 8e4c8f9

File tree

2 files changed

+9
-22
lines changed

2 files changed

+9
-22
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"@babel/runtime": "^7.11.2",
7878
"classnames": "2.x",
7979
"rc-dropdown": "^3.1.3",
80-
"rc-menu": "^8.6.1",
80+
"rc-menu": "^9.0.0-alpha.7",
8181
"rc-resize-observer": "^1.0.0",
8282
"rc-util": "^5.5.0"
8383
},

tests/overflow.test.tsx

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@ describe('Tabs.Overflow', () => {
2323
document.body.appendChild(holder);
2424

2525
function btnOffsetPosition() {
26+
// eslint-disable-next-line @typescript-eslint/no-invalid-this
2627
const btn = this as HTMLButtonElement;
27-
const btnList = [...btn.parentNode.childNodes].filter(ele =>
28+
const btnList = Array.from(btn.parentNode.childNodes).filter((ele) =>
2829
(ele as HTMLElement).className.includes('rc-tabs-tab'),
2930
);
3031
const index = btnList.indexOf(btn);
@@ -69,26 +70,18 @@ describe('Tabs.Overflow', () => {
6970
wrapper.find('.rc-tabs-nav-more').simulate('mouseenter');
7071
jest.runAllTimers();
7172
wrapper.update();
72-
expect(
73-
wrapper
74-
.find('.rc-tabs-dropdown li')
75-
.first()
76-
.text(),
77-
).toEqual('cute');
73+
expect(wrapper.find('.rc-tabs-dropdown li').first().text()).toEqual('cute');
7874

7975
// Click to select
80-
wrapper
81-
.find('.rc-tabs-dropdown-menu-item')
82-
.first()
83-
.simulate('click');
76+
wrapper.find('.rc-tabs-dropdown-menu-item').first().simulate('click');
8477
expect(onChange).toHaveBeenCalledWith('cute');
8578

8679
wrapper.unmount();
8780

8881
jest.useRealTimers();
8982
});
9083

91-
[KeyCode.SPACE, KeyCode.ENTER].forEach(code => {
84+
[KeyCode.SPACE, KeyCode.ENTER].forEach((code) => {
9285
it(`keyboard with select keycode: ${code}`, () => {
9386
jest.useFakeTimers();
9487
const onChange = jest.fn();
@@ -110,7 +103,7 @@ describe('Tabs.Overflow', () => {
110103
wrapper.find('.rc-tabs-nav-more').simulate('keydown', {
111104
which,
112105
});
113-
expect(wrapper.find('.rc-tabs-dropdown-menu-item-selected').text()).toEqual(match);
106+
expect(wrapper.find('li.rc-tabs-dropdown-menu-item-selected').text()).toEqual(match);
114107
}
115108

116109
keyMatch(KeyCode.DOWN, 'cute');
@@ -129,10 +122,7 @@ describe('Tabs.Overflow', () => {
129122
});
130123
wrapper.update();
131124
expect(
132-
wrapper
133-
.find('.rc-tabs-dropdown')
134-
.last()
135-
.hasClass('rc-tabs-dropdown-hidden'),
125+
wrapper.find('.rc-tabs-dropdown').last().hasClass('rc-tabs-dropdown-hidden'),
136126
).toBeFalsy();
137127

138128
// ESC
@@ -141,10 +131,7 @@ describe('Tabs.Overflow', () => {
141131
});
142132
wrapper.update();
143133
expect(
144-
wrapper
145-
.find('.rc-tabs-dropdown')
146-
.last()
147-
.hasClass('rc-tabs-dropdown-hidden'),
134+
wrapper.find('.rc-tabs-dropdown').last().hasClass('rc-tabs-dropdown-hidden'),
148135
).toBeTruthy();
149136

150137
wrapper.unmount();

0 commit comments

Comments
 (0)