Fix jest.spy

Author: wojtekmaj

packages/cli-doctor/src/tools/healthchecks/__tests__/androidSDK.test.ts

@@ -81,7 +81,7 @@ describe('androidSDK', () => {
       'android/build.gradle': `
         buildscript {
           ext {
-            buildToolsVersion = findProperty('android.buildToolsVersion') ?: '34.0.0' 
+            buildToolsVersion = findProperty('android.buildToolsVersion') ?: '34.0.0'
             minSdkVersion = 16
             compileSdkVersion = 28
             targetSdkVersion = 28
@@ -123,8 +123,8 @@ describe('androidSDK', () => {
 
   it('installs the SDK if it is missing on Windows', async () => {
     const loader = new tools.NoopLoader();
-    const loaderSucceedSpy = jest.spyOn(loader, 'succeed');
-    const loaderFailSpy = jest.spyOn(loader, 'fail');
+    const loaderSuccessSpy = jest.spyOn(loader, 'success');
+    const loaderErrorSpy = jest.spyOn(loader, 'error');
     const downloadAndUnzipSpy = jest
       .spyOn(downloadAndUnzip, 'downloadAndUnzip')
       .mockImplementation(() => Promise.resolve());
@@ -178,10 +178,10 @@ describe('androidSDK', () => {
       expect(requiredComponents.includes(call[0])).toBeTruthy();
     }
 
-    expect(loaderFailSpy).toHaveBeenCalledTimes(0);
+    expect(loaderErrorSpy).toHaveBeenCalledTimes(0);
     expect(logSpy).toHaveBeenCalledTimes(0);
 
-    expect(loaderSucceedSpy).toBeCalledWith(
+    expect(loaderSuccessSpy).toBeCalledWith(
       'Android SDK configured. You might need to restart your PC for all changes to take effect.',
     );
   });

packages/cli-doctor/src/tools/healthchecks/__tests__/androidStudio.test.ts

@@ -53,8 +53,8 @@ describe('androidStudio', () => {
 
   it('downloads and unzips Android Studio on Windows when missing', async () => {
     const loader = new NoopLoader();
-    const loaderSucceedSpy = jest.spyOn(loader, 'succeed');
-    const loaderFailSpy = jest.spyOn(loader, 'fail');
+    const loaderSuccessSpy = jest.spyOn(loader, 'success');
+    const loaderErrorSpy = jest.spyOn(loader, 'error');
     const downloadAndUnzipSpy = jest
       .spyOn(downloadAndUnzip, 'downloadAndUnzip')
       .mockImplementation(() => Promise.resolve());
@@ -65,10 +65,10 @@ describe('androidStudio', () => {
       environmentInfo,
     });
 
-    expect(loaderFailSpy).toHaveBeenCalledTimes(0);
+    expect(loaderErrorSpy).toHaveBeenCalledTimes(0);
     expect(logSpy).toHaveBeenCalledTimes(0);
     expect(downloadAndUnzipSpy).toBeCalledTimes(1);
-    expect(loaderSucceedSpy).toBeCalledWith(
+    expect(loaderSuccessSpy).toBeCalledWith(
       `Android Studio installed successfully in "${
         downloadAndUnzipSpy.mock.calls[0][0].installPath || ''
       }".`,

packages/cli-doctor/src/tools/healthchecks/__tests__/jdk.test.ts

@@ -73,8 +73,8 @@ describe('jdk', () => {
 
   it('downloads and unzips JDK on Windows when missing', async () => {
     const loader = new tools.NoopLoader();
-    const loaderSucceedSpy = jest.spyOn(loader, 'succeed');
-    const loaderFailSpy = jest.spyOn(loader, 'fail');
+    const loaderSuccessSpy = jest.spyOn(loader, 'success');
+    const loaderErrorSpy = jest.spyOn(loader, 'error');
     const downloadAndUnzipSpy = jest
       .spyOn(downloadAndUnzip, 'downloadAndUnzip')
       .mockImplementation(() => Promise.resolve());
@@ -85,10 +85,10 @@ describe('jdk', () => {
       environmentInfo,
     });
 
-    expect(loaderFailSpy).toHaveBeenCalledTimes(0);
+    expect(loaderErrorSpy).toHaveBeenCalledTimes(0);
     expect(logSpy).toHaveBeenCalledTimes(0);
     expect(downloadAndUnzipSpy).toBeCalledTimes(1);
-    expect(loaderSucceedSpy).toBeCalledWith(
+    expect(loaderSuccessSpy).toBeCalledWith(
       'JDK installed successfully. Please restart your shell to see the changes',
     );
   });

packages/cli-doctor/src/tools/healthchecks/__tests__/watchman.test.ts

@@ -82,8 +82,8 @@ describe('watchman', () => {
     });
 
     const loaderSpy = new NoopLoader();
-    const loaderSucceedSpy = jest.spyOn(loaderSpy, 'succeed');
-    const loaderFailSpy = jest.spyOn(loaderSpy, 'fail');
+    const loaderSuccessSpy = jest.spyOn(loaderSpy, 'success');
+    const loaderErrorSpy = jest.spyOn(loaderSpy, 'error');
     const brewInstallSpy = jest
       .spyOn(brewInstall, 'brewInstall')
       .mockImplementation(({loader}) => {
@@ -102,9 +102,9 @@ describe('watchman', () => {
       value: originalPlatform,
     });
 
-    expect(loaderFailSpy).toHaveBeenCalledTimes(0);
+    expect(loaderErrorSpy).toHaveBeenCalledTimes(0);
     expect(logSpy).toHaveBeenCalledTimes(0);
     expect(brewInstallSpy).toBeCalledTimes(1);
-    expect(loaderSucceedSpy).toBeCalledTimes(1);
+    expect(loaderSuccessSpy).toBeCalledTimes(1);
   });
 });