run yarn link in a way that is a bit more reslilient across OS/filesystem combinations. it looks like there's a latent race in e2e tests where sometimes a directory doesn't exist yet, or was already removed. this isn't a new issue, so check for directory before removal. trim stdout/stderr in the test helpers, not just in one test.

Author: matthargett

__e2e__/config.test.ts

@@ -51,7 +51,11 @@ beforeEach(() => {
   runCLI(DIR, ['init', 'TestProject', '--install-pods']);
 
   // Link CLI to the project
-  spawnScript('yarn', ['link', __dirname, '--all'], {
+  const cliPath = path.resolve(__dirname, '../packages/cli');
+  spawnScript('yarn', ['link'], {
+    cwd: cliPath,
+  });
+  spawnScript('yarn', ['link', '@react-native-community/cli'], {
     cwd: path.join(DIR, 'TestProject'),
   });
 });
@@ -108,7 +112,8 @@ test('should log only valid JSON config if setting up env throws an error', () =
       ? stderr
           .split('\n')
           .filter(
-            (line) => !line.startsWith('warn Multiple Podfiles were found'),
+            (line: string) =>
+              !line.startsWith('warn Multiple Podfiles were found'),
           )
           .join('\n')
       : stderr;
@@ -199,7 +204,7 @@ test('should fail if using require() in ES module in react-native.config.mjs', (
     'test-command-esm',
   ]);
   expect(stderr).toMatch('error Failed to load configuration of your project');
-  expect(stdout).toMatch(/Cannot require\(\) ES Module/);
+  expect(stdout).toMatch(/require is not defined in ES module scope/);
 });
 
 test('should fail if using require() in ES module with "type": "module" in package.json', () => {

__e2e__/root.test.ts

@@ -19,7 +19,11 @@ beforeAll(() => {
   runCLI(DIR, ['init', 'TestProject', `--pm`, 'npm', `--install-pods`]);
 
   // Link CLI to the project
-  spawnScript('yarn', ['link', __dirname, '--all'], {
+  const cliPath = path.resolve(__dirname, '../packages/cli');
+  spawnScript('yarn', ['link'], {
+    cwd: cliPath,
+  });
+  spawnScript('yarn', ['link', '@react-native-community/cli'], {
     cwd: path.join(DIR, 'TestProject'),
   });
 });

jest/helpers.ts

@@ -45,7 +45,9 @@ export const makeTemplate =
     });
 
 export const cleanup = (directory: string) => {
-  fs.rmSync(directory, {recursive: true, force: true, maxRetries: 10});
+  if (fs.existsSync(directory)) {
+    fs.rmSync(directory, {recursive: true, force: true, maxRetries: 10});
+  }
 };
 
 /**
@@ -115,8 +117,8 @@ export const spawnScript: SpawnFunction<any> = (execPath, args, options) => {
   // Transform spawnSync result to match execa format
   const execaLikeResult = {
     exitCode: result.status || 0,
-    stdout: result.stdout || '',
-    stderr: result.stderr || '',
+    stdout: result.stdout?.trim() || '',
+    stderr: result.stderr?.trim() || '',
     failed: result.status !== 0,
   };