Add proposal for migrating AlertDialog#784
Open
Abbondanzo wants to merge 2 commits intoreact-native-community:mainfrom
Open
Add proposal for migrating AlertDialog#784Abbondanzo wants to merge 2 commits intoreact-native-community:mainfrom
Abbondanzo wants to merge 2 commits intoreact-native-community:mainfrom
Conversation
Author
|
Some past works include: |
Author
|
Proof-of-concept: |
cortinico
approved these changes
Jun 6, 2024
Member
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
LGTM 👍 Just left minor questions to clarify the text
|
|
||
| ## Adoption strategy | ||
|
|
||
| This introduces a subtle breaking change in the form of theme support changes. Theming is now applied via `alertDialogTheme`, not `android:alertDialogTheme`. We would have to include a blurb in the release about the theme changes and dropping support for `android.app.AlertDialog`. |
Member
There was a problem hiding this comment.
I suspect the impact of this change will be minimal. I expect most of the brownfield users to use AppCompatActivity already.
Member
There was a problem hiding this comment.
Also cc @javache as we discussed about Activity vs AppCompatActivity
Add a release versioning strategy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to androidx.appcompat.app.AlertDialog
This proposal suggests migrating all existing uses of
android.app.AlertDialogtoandroidx.appcompat.app.AlertDialogto add support library features. Currently, the two primary uses are in theAlertFragmentandDevSupportManagerBaseclasses.