Open
Conversation
lucasbento
approved these changes
Jun 14, 2025
kelset
reviewed
Jun 16, 2025
| @@ -1 +0,0 @@ | |||
| 16.19.1 | |||
Member
There was a problem hiding this comment.
should we have something equivalent (but recent) in the package.json? the engine field? I think we realistically dont want to be under Node 22 (but i might be wrong)
Member
Author
There was a problem hiding this comment.
its part of the mise.toml file :) ill update everywhere else too.
kelset
reviewed
Jun 16, 2025
Comment on lines
+35
to
+42
| # lint: | ||
| # needs: [setup, install] | ||
| # runs-on: ubuntu-latest | ||
| # steps: | ||
| # - name: ⬇️ Restore output | ||
| # uses: actions/download-artifact@v4 | ||
| # with: | ||
| # name: ${{ github.sha }} |
Member
There was a problem hiding this comment.
did you just commented them out temporarely or it's intentional to have it commented here?
Member
Author
There was a problem hiding this comment.
i wanted to see if i can just get this running or not. not a permanent thing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
What are the steps to reproduce?
Checklist
README.md(if needed)