Separate out theming into its own pacakge. #3268
flyingcircle
started this conversation in
Ideas
Replies: 3 comments 2 replies
-
Will |
Beta Was this translation helpful? Give feedback.
0 replies
-
Yeah that's my thinking. Basically pull out the default HOC, and have a separate package where that is added to the components. |
Beta Was this translation helpful? Give feedback.
2 replies
This comment has been hidden.
This comment has been hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Theming in RNE is unique in that I don't know of any other theming package in React Native that handles theming the way we do. Unfortunately however, during the move to typescript, it became clear that reasoning around the types for theming is complicated, and any user of RNE that doesn't want to use themes has an unnecessary added layer of complexity.
My suggestion here is that for RNE 5.0, we remove theming and extract out into its own pacakge
react-native-elements-themed
. Can anyone think of pros/cons to this?CC: @Monte9 @pranshuchittora @arpitBhalla @khushal87
Or perhaps if we continue to expand the number of packages in RNE we should start scoping the package names:
@react-native-elements/base
@react-native-elements/themed
etc.Beta Was this translation helpful? Give feedback.
All reactions