-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Update theme_object.mdx #3986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme_object.mdx #3986
Conversation
|
Hello @HadiaRafiq - thank you for the PR! I am a new contributor and am working to review and merge your PR. I found a few issues that need to be addressed: 1. Syntax Error
Should be:
2. Incorrect Default Values The examples don't match the actual defaults in the codebase. According to 3. Interface Naming For consistency with the source code and the Colors section pattern, consider using Could you update the PR to fix the syntax error and use the correct default values & naming? EDIT: Made changes myself, will merge |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3986 +/- ##
=======================================
Coverage 79.29% 79.29%
=======================================
Files 90 90
Lines 2144 2144
Branches 946 959 +13
=======================================
Hits 1700 1700
Misses 442 442
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update theme_object.mdx
Update theme_object.mdx
Motivation
The spacing object was added to the theme to provide a standardized and scalable way to manage layout spacing (such as padding, margin, and gaps) across the app. Hardcoding pixel values often leads to inconsistent UI and makes global updates difficult. By centralizing spacing in the theme, we enable consistent styling, easier maintenance, and better alignment with design systems.
How Has This Been Tested?
exampleappChecklist
yarn docs-build-apiAdditional context