Removed bogus .Filter() overload
#1013
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upply filtering logic, resulting in all items always being filtered out.
JakenVeina
added
Housekeeping
JakenVeina
requested review from
RolandPheasant
and removed request for
ChrisPulman
|
Is it a breaking change if no one is using it? If it does not work, how could anyone be using it? Better safe than sorry, I guess. |
|
Normally with a breaking change we would bump the major version. However in this case, the overload is meaningless so should we keep the major version or bump? Thoughts? |
|
I'm a "technically correct is the best kind of correct" kinda person, so I say keep it a major bump. Except, I don't think there's any need to bother bumpibg it ONLY for this. I'd just have us hold onto it until the next time we have something to trigger a major bump that's actually meaningful. |
dwcullop
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a bogus .Filter() overload that did not allow the consumer to supply filtering logic, resulting in all items always being filtered out.
This appears to have been mistakenly introduced during a refactor, in commit 3657fee.
This is a breaking change that we can just include the next time we happen to have a major version release. I don't think it's worth doing a cycle of marking this deprecated, as the operator is just fully-defective.