Build: use 24h for build API token expiry date (#12469)

We are still hitting issues with expired tokens. This commit increases
the expiry date to 24hs as an initial test to try to mitigate this issue
and have more data about the surrounding problems.

Closes #12467

Author: humitos

readthedocs/api/v2/models.py

@@ -1,6 +1,5 @@
 from datetime import timedelta
 
-from django.conf import settings
 from django.db import models
 from django.utils import timezone
 from django.utils.translation import gettext_lazy as _
@@ -24,9 +23,17 @@ def create_key(self, project):
 
         and can be revoked at any time by hitting the /api/v2/revoke/ endpoint.
         """
-        delta = (
-            project.container_time_limit or settings.BUILD_TIME_LIMIT
-        ) * 1.25 + settings.RTD_BUILDS_RETRY_DELAY * settings.RTD_BUILDS_MAX_RETRIES
+        # delta = (
+        #     project.container_time_limit or settings.BUILD_TIME_LIMIT
+        # ) * 1.25 + settings.RTD_BUILDS_RETRY_DELAY * settings.RTD_BUILDS_MAX_RETRIES
+        #
+        # Use 24 hours for now since we are hitting the expiry date and we shouldn't
+        # https://github.com/readthedocs/readthedocs.org/issues/12467
+        #
+        # NOTE: this is the maximum time this token will be valid, since the
+        # default behavior is to revoke from the builder itself when the build
+        # at `after_return` immediately before the build finishes
+        delta = 60 * 60 * 24  # 24h
         expiry_date = timezone.now() + timedelta(seconds=delta)
         name_max_length = self.model._meta.get_field("name").max_length
         return super().create_key(

readthedocs/rtd_tests/tests/test_api.py

@@ -814,14 +814,14 @@ def test_expiricy_key(self):
         project = get(Project)
         build_api_key_obj, build_api_key = BuildAPIKey.objects.create_key(project)
         expected = (build_api_key_obj.expiry_date - timezone.now()).seconds
-        self.assertAlmostEqual(expected, 8250, delta=5)
+        self.assertAlmostEqual(expected, 86400, delta=5)
 
         # Project with a custom containe time limit
         project.container_time_limit = 1200
         project.save()
         build_api_key_obj, build_api_key = BuildAPIKey.objects.create_key(project)
         expected = (build_api_key_obj.expiry_date - timezone.now()).seconds
-        self.assertAlmostEqual(expected, 9000, delta=5)
+        self.assertAlmostEqual(expected, 86400, delta=5)
 
     def test_user_doesnt_get_full_api_return(self):
         user_normal = get(User, is_staff=False)