We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I click visual diff, it diffs correctly. Instead, it currently throws an error.
this.performDiff(this.cachedRemoteResponse.content); // ... const htmlDocument = parser.parseFromString(remoteContent, "text/html"); const oldBody = htmlDocument.documentElement.querySelector( this.rootSelector, );
The JS fetches this url: https://prairielearn--11830.org.readthedocs.build/_/api/v3/embed/?url=https%3A%2F%2Fprairielearn.readthedocs.io%2Fen%2Flatest%2Fquestion%2Findex.html&maincontent=main+%3E+div+%3E+div.md-content
The content it fetches is at the root selector:
It then tries to select the root node of the fetched document, and fails, since it has already fetched it!
The text was updated successfully, but these errors were encountered:
This looks like a regression in readthedocs/addons@a6623bf.
Sorry, something went wrong.
No branches or pull requests
Details
Expected Result
When I click visual diff, it diffs correctly. Instead, it currently throws an error.
Actual Result
The JS fetches this url: https://prairielearn--11830.org.readthedocs.build/_/api/v3/embed/?url=https%3A%2F%2Fprairielearn.readthedocs.io%2Fen%2Flatest%2Fquestion%2Findex.html&maincontent=main+%3E+div+%3E+div.md-content
The content it fetches is at the root selector:
It then tries to select the root node of the fetched document, and fails, since it has already fetched it!
Fix: don't select content at the root selector once it has been fetched through the embed link.
The text was updated successfully, but these errors were encountered: