Save last login method in a cookie

[humitos]

Initial attempt to save the "last login method" into a cookie so we can show a visual label next to the button to login.

This is only the backend part. We need to write some code in the template to use this value next.

I'm not happy with the implementation because looks pretty complex. I didn't find an easier way to do it and I'm open for suggestions.

Required by readthedocs/ext-theme#421

[agjohnson]

Alternatively, we could use basic events on elements in the login UI to set a cookie from the client side. If the user last clicked on the GitHub button or Email tab, we store that and either consume it at the backend and use it as context data into the view, or it's also possible to do this all on the front end side but it will be a fair amount of JS.

[humitos]

What about subscribing to all the social buttons and email's submit button and use using cookieStore.set() in the frontend to save the cookie? This cookie will be sent to the server and we can read it from the backend to render the template with this value. I think that's probably the best of the two worlds.

[ericholscher]

Seems like hooking into allauth is probably the right place here? Doing middleware feels really heavy. I looked briefly at the docs and couldn't find an obvious place. @stsewd do you know if there's a good spot to hook here?

[agjohnson]

What about subscribing to all the social buttons and email's submit button and use using cookieStore.set() in the frontend to save the cookie? This cookie will be sent to the server and we can read it from the backend to render the template with this value

Is this different than what I suggested? #12286 (comment)

Seems like you're suggesting the same thing, I think that's fine yeah.

[humitos]

Seems like you're suggesting the same thing,

Now that I re-read your comment, it seems I'm suggesting the same, yeah haha 😅

I tried cookieStorage.set() the other day but it fails locally because it's not secure:

Secure context: This feature is available only in secure contexts (HTTPS), in some or all supporting browsers.

(from https://developer.mozilla.org/en-US/docs/Web/API/CookieStore/set)

So, I will need to disable that somehow for developing or add SSL somehow to the local environment.

[humitos]

This is now working as I want. We read the cookie set by the front-end and expose 2 variables in the context for the templates:

• last_login_method: it will be the provider.id set by the front end (github, githubapp, sso, etc)
• last_login_tab: it will communicate the front-end what's the tab should be activated (vcs, email, sso)

[stsewd]

I'd be fine with this, but still think just having this on the client side with the local storage makes more sense. @agjohnson probably knows better how much work that would be, we are already using bindings to hide content based on conditions.

[humitos]

@stsewd we already discussed this in #12286 (comment)