Build overview: don't create comment for projects with empty diffs #12291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't remember were we ended finally. Are we posting only one comment or a comment per build/push? If we are posting multiple comments, what comment will we update when there is no file changes? |
humitos
reviewed
Jul 10, 2025
One comment per project |
readthedocs/oauth/services/base.py
Outdated
| @@ -111,8 +111,13 @@ def get_clone_token(self, project): | |||
| """Get a token used for cloning the repository.""" | |||
| raise NotImplementedError | |||
|
|
|||
| def post_comment(self, build, comment: str): | |||
| """Post a comment on the pull request attached to the build.""" | |||
| def post_comment(self, build, comment: str, update_only: bool = False): | |||
There was a problem hiding this comment.
Seems this didn't get updated?
ericholscher
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we don't create comments when no files have been changed, but we still update the comment if we already reported a build with changed files.