Make doc preview more prominent and remove headings #12295
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the content is self-explanatory, and the huge header is not adding value. I think the primary action should be the biggest text. I'd like to see that become a button though.
Documentation build overviewFiles changedShow files (4) | 3 modified | 1 added | 0 deleted
|
We can probably use a badge here or a quick solution is to use |
|
I think we all have different taste here for how this comment should be and it seems we will be iterating quickly in the next weeks/months, so I'd suggest to mark this feature as beta and communicate clearly what to expect at this early stage. |
|
I think it's very verbose now, so we should definitely get three changes or similar in. |
|
@stsewd I'd still like to see something like this make it in. I find the current message has a lot of text that isn't really needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the content is self-explanatory,
and the huge header is not adding value.
I think the primary action should be the biggest text.
I'd like to see that become a button,
but baby steps.