Skip to content

Addons: add linkpreviews.selector field #12301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 8, 2025

This field is used to allow users to customize the CSS selector used by addons to grab all the links where they want to apply link previews addons.

Required by readthedocs/addons#554

This field is used to allow users to customize the CSS selector used by addons
to grab all the links where they want to apply link previews addons.

Required by readthedocs/addons#554
@humitos humitos requested a review from a team as a code owner July 8, 2025 09:55
@humitos humitos requested a review from stsewd July 8, 2025 09:55
humitos added a commit to readthedocs/addons that referenced this pull request Jul 8, 2025
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not be using the options_root_selector selector for this? I don't understand how this is different, and it's not documented.

@humitos
Copy link
Member Author

humitos commented Jul 10, 2025

Should we not be using the options_root_selector selector for this? I don't understand how this is different

options_root_selector is to grab the main content node of the page. linkpreviews_selector is to grab all the links from the page were link previews will be injected.

@humitos humitos requested a review from ericholscher July 14, 2025 10:07
@humitos
Copy link
Member Author

humitos commented Jul 15, 2025

This is the only PR missing for an approval to be able to deploy this feature. Can I have a final review here?

humitos added a commit to readthedocs/addons that referenced this pull request Jul 15, 2025
@humitos humitos merged commit ff7ac93 into main Jul 15, 2025
7 checks passed
@humitos humitos deleted the humitos/link-previews-selector branch July 15, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants