-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Projects: create integration for GitHub App projects #12322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough
c063071
to
adcca9b
Compare
This looks accurate to me. We should do the opposite as well. Create the integration when the user manually connects the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, with some comments.
The next step here would be to create the HTTP exchanges when we receive the events from GitHub and associate them to this integration. That way we will have the logs similar to the other integrations.
That is what this PR does as well |
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
I guess there is the question about how/when to delete these... I think if the user disconnects the project manually (selecting None on the connected repo option), then we should delete the integration, we could also enable the delete button for the integration as well, and that will delete the integration and also set the project's remote repo to None.