Skip to content

Projects: create integration for GitHub App projects #12322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 16, 2025

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jul 14, 2025

I guess there is the question about how/when to delete these... I think if the user disconnects the project manually (selecting None on the connected repo option), then we should delete the integration, we could also enable the delete button for the integration as well, and that will delete the integration and also set the project's remote repo to None.

@stsewd stsewd requested a review from a team as a code owner July 14, 2025 21:27
@stsewd stsewd requested a review from ericholscher July 14, 2025 21:27
@stsewd stsewd requested a review from agjohnson July 14, 2025 21:27
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

@stsewd stsewd force-pushed the create-integration-gh-app-projects branch from c063071 to adcca9b Compare July 15, 2025 18:51
@humitos
Copy link
Member

humitos commented Jul 16, 2025

I guess there is the question about how/when to delete these... I think if the user disconnects the project manually (selecting None on the connected repo option), then we should delete the integration, we could also enable the delete button for the integration as well, and that will delete the integration and also set the project's remote repo to None.

This looks accurate to me. We should do the opposite as well. Create the integration when the user manually connects the project.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, with some comments.

The next step here would be to create the HTTP exchanges when we receive the events from GitHub and associate them to this integration. That way we will have the logs similar to the other integrations.

@stsewd
Copy link
Member Author

stsewd commented Jul 16, 2025

We should do the opposite as well. Create the integration when the user manually connects the project.

That is what this PR does as well

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
@stsewd stsewd merged commit 1423438 into main Jul 16, 2025
7 checks passed
@stsewd stsewd deleted the create-integration-gh-app-projects branch July 16, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants