Skip to content

Conversation

CameronMcClymont
Copy link
Member

@CameronMcClymont CameronMcClymont commented Jul 18, 2025

Hides the following section on the profile page when the REANA_GITLAB_HOST Helm value is not set:

image

Closes #428
See also reanahub/reana-server#740

@CameronMcClymont CameronMcClymont force-pushed the hide-gitlab-when-unconfigured branch from dbe21c8 to 48a69da Compare July 18, 2025 13:08
@CameronMcClymont
Copy link
Member Author

It looks like the Helm value in reana/helm/reana/templates/secrets.yaml has a default value, in which case REANA_GITLAB_HOST will always be set? Will this be the case on non-CERN instances?

REANA_GITLAB_HOST: {{ .Values.secrets.gitlab.REANA_GITLAB_HOST | default "gitlab.cern.ch" | b64enc }}

@tiborsimko
Copy link
Member

tiborsimko commented Aug 21, 2025

Will this be the case on non-CERN instances?

Yes, the current implementation uses gitlab.cern.ch by default, so we are kind of forcing CERN GitLab integration upon existing instances. Which does not make too much sense.

If an instance wants to switch off the GitLab features, they need to use:

secrets:
  gitlab:
    REANA_GITLAB_HOST: ""

This works fine, i.e. the /api/info endpoint returns empty string, and the web interface does not show anything related to GitLab with your PR:

Screenshot 2025-08-21 at 14 31 13

We can live with this, I think, since it addresses problem already 👍 and we can perhaps prettify the default REANA_GITLAB_HOST handling business later.

P.S. Would you have an analogous change for the command-line clients, so that reana-client info would show whether or not the remote REANA server is attached to some GitLab instance, and if so, to which one? If not, we can merge this already and add the same functionality to CLI clients also later.

P.S. We may also want to go through r-server etc code bases on the server side to check that nothing bad is happening when REANA_GITLAB_HOST is set to an empty string...

@CameronMcClymont
Copy link
Member Author

CameronMcClymont commented Aug 26, 2025

Regarding adding GitLab connection info to reana-client info, I believe this is covered by reanahub/reana-server#740?

$ gh pr checkout 740 --repo reanahub/reana-server
$ reana-client info

/Users/cmcclymont/.virtualenvs/reana/lib/python3.12/site-packages/reana_commons/config.py:15: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  import pkg_resources
List of supported compute backends: kubernetes
CWL engine tool: cwltool
CWL engine version: 3.1.20210628163208
Dask workflows allowed in the cluster: False
Default timeout for Kubernetes jobs: 604800
Default memory limit for Kubernetes jobs: 4Gi
Default workspace: /var/reana
GitLab host: gitlab.cern.ch
Recommended Jupyter images for interactive sessions: quay.io/jupyter/scipy-notebook:notebook-7.2.2
Users can set custom interactive session images: False
Maximum allowed memory limit for Kubernetes jobs: None
Maximum inactivity period in days before automatic closure of interactive sessions: None
Maximum timeout for Kubernetes jobs: 1209600
Maximum retention period in days for workspace files: None
Snakemake engine version: 8.27.1
List of supported workflow engines: cwl, serial, snakemake, yadage
List of available workspaces: /var/reana
Yadage engine adage version: 0.11.0
Yadage engine packtivity version: 0.16.2
Yadage engine version: 0.20.1

@CameronMcClymont
Copy link
Member Author

I have had a look through the codebases and REANA_GITLAB_HOST is only used in reana, reana-server, and reana-workflow-controller. In all cases, if REANA_GITLAB_HOST is an empty string there should be no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

your profile: hide GitLab box when not configured by the admins
2 participants