Modernize build files, upgrade Bazel #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR is queued for merge (review queue position). It will be merged when it reaches the top of the queue and all required status checks are passing. Pending Status Checks
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
rileysdev
approved these changes
Sep 23, 2025
|
This pull request failed to merge: this PR has conversations which must be resolved before merging. After you have resolved the problem, you should remove the |
* Upgrade to Bazel 7 * Upgrade to `rules_python` 1.0.0 and fix breakage * Upgrade to protobuf 29.5 * Use `py_proto_library` and `ProtoInfo` from the protobuf repo, not `rules_proto` (deprecated); we also neglected to properly import the dependency on `rules_proto` anyway. * Use `cc_proto_library` from the protobuf repo, not `rules_cc` (deprecated) * Actually run the cpp test in `bazel test` * Remove `repo_mapping` cruft (isn't supported in modern Bazel versions anyway).
neilconway
force-pushed
the
neilc/bazel-upgrade
branch
from
9efe3c2 to
7540389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_proto1.0.0 and fix breakagepy_proto_libraryfrom the protobuf repo, notrules_proto(deprecated)cc_proto_libraryfrom the protobuf repo, notrules_cc(deprecated)bazel testrepo_mappingcruft (isn't supported in modern Bazel versions anyway).