Skip to content

fix:#7 Improve Error Handling in smart-contract #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shebll
Copy link

@shebll shebll commented Oct 1, 2024

Description

  • Improve Error Handling in smart-contract by extending Error class for making ContractConfigurationError for throw error instead of return undefined
  • init the jest test config and install jest in -D
  • move a test folder in src folder for better organizing
  • make a unit test for getContract
  • comment other unit tests it makes errors in the testing run
  • todo for makeBeacon and fix other unit tests

Testing (ignore for documentation update)

  • init the jest test config and install jest in -D
  • move a test folder in src folder for better organizing
  • make a unit test for getContract
  • comment other unit tests it makes errors in the testing run
  • todo for makeBeacon and fix other unit tests

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist:

Additional Notes:

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2024

CLA assistant check
All committers have signed the CLA.

@AbdulRashidReshamwala
Copy link
Contributor

can you remove the packagelock changes from the pr will cause multiple issue during review

@adithyaakrishna
Copy link
Contributor

@shebll Could you pls resolve the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants