-
Notifications
You must be signed in to change notification settings - Fork 94
[Symfony 7.3] Add RegexToSlugConstraintRector #723 #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JohJohan
wants to merge
1
commit into
rectorphp:main
Choose a base branch
from
JohJohan:RegexToSlugConstraintRector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
config/sets/symfony/symfony7/symfony73/symfony73-validator.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
use Rector\Config\RectorConfig; | ||
use Rector\Symfony\Symfony73\Rector\New_\RegexToSlugConstraintRector; | ||
|
||
return static function (RectorConfig $rectorConfig): void { | ||
// @see https://symfony.com/blog/new-in-symfony-7-3-slug-and-twig-constraints#slug-constraint | ||
$rectorConfig->rule(RegexToSlugConstraintRector::class); | ||
}; |
31 changes: 31 additions & 0 deletions
31
rules-tests/Symfony73/Rector/New_/RegexToSlugConstraintRector/Fixture/replace.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class Replace | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Regex('/[a-z0-9]+(?:-[a-z0-9]+)*/'); | ||
} | ||
} | ||
|
||
?> | ||
----- | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class Replace | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Symfony\Component\Validator\Constraints\Slug(); | ||
} | ||
} | ||
|
||
?> |
31 changes: 31 additions & 0 deletions
31
...ests/Symfony73/Rector/New_/RegexToSlugConstraintRector/Fixture/replace_all_params.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class ReplaceAllParams | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Regex(pattern: '/[a-z0-9]+(?:-[a-z0-9]+)*/', message: 'some message', htmlPattern: null, match: null, normalizer: null, groups: ['Default'], payload: null, options: []); | ||
} | ||
} | ||
|
||
?> | ||
----- | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class ReplaceAllParams | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Symfony\Component\Validator\Constraints\Slug(message: 'some message', groups: ['Default'], payload: null, options: []); | ||
} | ||
} | ||
|
||
?> |
31 changes: 31 additions & 0 deletions
31
...fony73/Rector/New_/RegexToSlugConstraintRector/Fixture/replace_param_array_syntax.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class ReplaceParamArraySyntax | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Regex(['pattern' => '/^[a-z0-9]+(?:-[a-z0-9]+)*$/']); | ||
} | ||
} | ||
|
||
?> | ||
----- | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class ReplaceParamArraySyntax | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Symfony\Component\Validator\Constraints\Slug(); | ||
} | ||
} | ||
|
||
?> |
31 changes: 31 additions & 0 deletions
31
...fony73/Rector/New_/RegexToSlugConstraintRector/Fixture/replace_start_and_end_tags.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class ReplaceStartAndEndTags | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Regex('/^[a-z0-9]+(?:-[a-z0-9]+)*$/'); | ||
} | ||
} | ||
|
||
?> | ||
----- | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class ReplaceStartAndEndTags | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Symfony\Component\Validator\Constraints\Slug(); | ||
} | ||
} | ||
|
||
?> |
31 changes: 31 additions & 0 deletions
31
...ests/Symfony73/Rector/New_/RegexToSlugConstraintRector/Fixture/replace_with_alias.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class ReplaceWithAlias | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Assert\Regex('/^[a-z0-9]+(?:-[a-z0-9]+)*$/'); | ||
} | ||
} | ||
|
||
?> | ||
----- | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class ReplaceWithAlias | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Symfony\Component\Validator\Constraints\Slug(); | ||
} | ||
} | ||
|
||
?> |
15 changes: 15 additions & 0 deletions
15
...sts/Symfony73/Rector/New_/RegexToSlugConstraintRector/Fixture/skip_diffrent_regex.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class SkipDifferentRegex | ||
{ | ||
public function createConstraint() | ||
{ | ||
return new Regex('/^[a-z0-9]$/'); | ||
} | ||
} | ||
|
||
?> |
15 changes: 15 additions & 0 deletions
15
...sts/Symfony73/Rector/New_/RegexToSlugConstraintRector/Fixture/skip_variable_regex.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<?php | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector\Fixture; | ||
|
||
use Symfony\Component\Validator\Constraints\Regex; | ||
|
||
class SkipDifferentRegex | ||
{ | ||
public function createConstraint(string $regex = '/^[a-z0-9]+(?:-[a-z0-9]+)*$/') | ||
{ | ||
return new Regex($regex); | ||
} | ||
} | ||
|
||
?> |
28 changes: 28 additions & 0 deletions
28
...sts/Symfony73/Rector/New_/RegexToSlugConstraintRector/RegexToSlugConstraintRectorTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Rector\Symfony\Tests\Symfony73\Rector\New_\RegexToSlugConstraintRector; | ||
|
||
use Iterator; | ||
use PHPUnit\Framework\Attributes\DataProvider; | ||
use Rector\Testing\PHPUnit\AbstractRectorTestCase; | ||
|
||
final class RegexToSlugConstraintRectorTest extends AbstractRectorTestCase | ||
{ | ||
#[DataProvider('provideData')] | ||
public function test(string $filePath): void | ||
{ | ||
$this->doTestFile($filePath); | ||
} | ||
|
||
public static function provideData(): Iterator | ||
{ | ||
return self::yieldFilesFromDirectory(__DIR__ . '/Fixture'); | ||
} | ||
|
||
public function provideConfigFilePath(): string | ||
{ | ||
return __DIR__ . '/config/configured_rule.php'; | ||
} | ||
} |
10 changes: 10 additions & 0 deletions
10
rules-tests/Symfony73/Rector/New_/RegexToSlugConstraintRector/config/configured_rule.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
use Rector\Config\RectorConfig; | ||
use Rector\Symfony\Symfony73\Rector\New_\RegexToSlugConstraintRector; | ||
|
||
return static function (RectorConfig $rectorConfig): void { | ||
$rectorConfig->rule(RegexToSlugConstraintRector::class); | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe i should skip if
htmlPattern
,match
ornormalizer
are part of the params?