Allow group selection in logging.addRewriter (#918)

gigabo · web-flow · commit 8752ce29be2a · 2017-04-07T15:18:39.000-07:00
This makes it possible to add a rewriter only for the main logger, for example.

This also makes the interface consistent with `addTransport` and `setLevel`.

This is a breaking change.
diff --git a/packages/react-server/core/logging/server.js b/packages/react-server/core/logging/server.js
@@ -123,8 +123,10 @@ function addTransport(group, transport) {
 	});
 }
 
-function addRewriter(rewriter) {
-	common.forEachLogger(logger => logger.rewriters.push(rewriter));
+function addRewriter(group, rewriter) {
+	common.forEachLogger((logger, loggerGroup) => {
+		if (loggerGroup === group) logger.rewriters.push(rewriter);
+	});
 }
 
 function setTimestamp(bool) {

Original file line number	Diff line number	Diff line change
`@@ -123,8 +123,10 @@ function addTransport(group, transport) {`
`123`	`123`	`});`
`124`	`124`	`}`
`125`	`125`
`126`		`-function addRewriter(rewriter) {`
`127`		`- common.forEachLogger(logger => logger.rewriters.push(rewriter));`
	`126`	`+function addRewriter(group, rewriter) {`
	`127`	`+ common.forEachLogger((logger, loggerGroup) => {`
	`128`	`+ if (loggerGroup === group) logger.rewriters.push(rewriter);`
	`129`	`+ });`
`128`	`130`	`}`
`129`	`131`
`130`	`132`	`function setTimestamp(bool) {`