Skip to content

fix: Modification to replace the usage of deprecated constructor SymbolInformation with WorkspaceSymbol #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Modification to replace the usage of deprecated constructor SymbolInformation with WorkspaceSymbol #1424

wants to merge 3 commits into from

Conversation

anusreelakshmi934
Copy link
Contributor

Fixes #1423

  • Replaced deprecated constructor SymbolInformation with WorkspaceSymbol

  • Additionally, this also addresses the deprecation of the following methods:

    • SymbolInformation.setName(String)
    • SymbolInformation.setLocation(Location)
    • SymbolInformation.setKind(SymbolKind)

  • Changed copyright year to 2025

@anusreelakshmi934
Copy link
Contributor Author

anusreelakshmi934 commented Jan 15, 2025 •
edited
Loading

@angelozerr, kindly review this PR at your convenience. Thanks

@anusreelakshmi934 anusreelakshmi934 mentioned this pull request Jan 15, 2025
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anusreelakshmi934 anusreelakshmi934 mentioned this pull request Feb 11, 2025
Open
@anusreelakshmi934
Copy link
Contributor Author

Hi @angelozerr, could you please review this PR? We're wrapping up issues for our upcoming release milestone, so it would be greatly appreciated if you could take a look at it as soon as possible. Thanks!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anusreelakshmi934
Copy link
Contributor Author

Hi @angelozerr I have resolved the conflicts in this PR.

@angelozerr
Copy link
Contributor

@anusreelakshmi934 your PR doesn't compile the project.

For instance https://github.com/redhat-developer/intellij-quarkus/actions/runs/13780484873/job/38537711426?pr=1424#step:6:61

@angelozerr
Copy link
Contributor

It seems you are using WorskpaceSymbol, but in this case you cannot do that because MP LS works with SymbolInformation.

If you want to work with WorkspaceSympl, you will need to update MP LS and MP JDT. I am not against this idea but it will require more work in LSP4MP:

@anusreelakshmi934 anusreelakshmi934 mentioned this pull request Mar 14, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address usage of deprecated constructor SymbolInformation
2 participants
@anusreelakshmi934 @angelozerr