Skip to content

Conversation

@christoph-jerolimov
Copy link
Member

Description

This is a manual cherry-pick of #3605 to backport this fixes:

  1. aligned pre-installed comment to make it clear why this is needed
  2. marked mcp-chat as "plugin yaml" is pre-installed
  3. removed pre-installed comment from github-insights description
  4. removed scaffolder-integrations plugin (which was more a collection)
  5. revert rename of parfuemerie-douglas/scaffolder-backend-module-azure-repositories package entity to resolve entity name is 'too long' issue

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

kind: Package
metadata:
name: parfuemerie-douglas-scaffolder-backend-module-azure-repositories
name: parfuemerie-douglas-scaffolder-backend-module-azure-repositorie
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because the name is too long otherwise. It's the same as in 1.7 and earlier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to also update the filename

Copy link
Member

@dzemanov dzemanov Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would let it be for now, since we are past CF, Christoph is on vacation and this is 1.8 cherry-pick. We can revisit it later. It makes sense to have filenames and Component names to match. However, then it is hard to locate the files, the issue came up for example in this PR where multiple existing packages were missed as a result of this stripping. To locate catalog backend module marketplace which is named red-hat-developer-hub-backstage-plugin-catalog-backend-module-m is a task 😄. There was a suggestion to have consistent renaming. For example red-hat-developer-hub -> rhdh, some plugins are already named like this. Not sure if any task was created for that @nickboldt.

Copy link
Member

@nickboldt nickboldt Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup task created in https://issues.redhat.com/browse/RHIDP-9492 -- I agree we should start being consistent w/ the naming rules.

@github-actions
Copy link
Contributor

@christoph-jerolimov
Copy link
Member Author

/retest

1 similar comment
@dzemanov
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

@christoph-jerolimov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 8ce53a0 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt merged commit a474af3 into redhat-developer:release-1.8 Oct 23, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants