-
Notifications
You must be signed in to change notification settings - Fork 210
[release-1.8] fix: fix multiple small catalog issues #3614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.8] fix: fix multiple small catalog issues #3614
Conversation
| kind: Package | ||
| metadata: | ||
| name: parfuemerie-douglas-scaffolder-backend-module-azure-repositories | ||
| name: parfuemerie-douglas-scaffolder-backend-module-azure-repositorie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because the name is too long otherwise. It's the same as in 1.7 and earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to also update the filename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would let it be for now, since we are past CF, Christoph is on vacation and this is 1.8 cherry-pick. We can revisit it later. It makes sense to have filenames and Component names to match. However, then it is hard to locate the files, the issue came up for example in this PR where multiple existing packages were missed as a result of this stripping. To locate catalog backend module marketplace which is named red-hat-developer-hub-backstage-plugin-catalog-backend-module-m is a task 😄. There was a suggestion to have consistent renaming. For example red-hat-developer-hub -> rhdh, some plugins are already named like this. Not sure if any task was created for that @nickboldt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followup task created in https://issues.redhat.com/browse/RHIDP-9492 -- I agree we should start being consistent w/ the naming rules.
|
The image is available at: |
|
/retest |
1 similar comment
|
/retest |
|
@christoph-jerolimov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
nickboldt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a474af3
into
redhat-developer:release-1.8
Description
This is a manual cherry-pick of #3605 to backport this fixes:
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer