Skip to content

Commit f05aa11

Browse files
committed
fixup: Bump vscode-extension-tester from 8.11.0 to 8.18.0 #5386
Disable the scan via '@secretlint/node' Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
1 parent f0eba2b commit f05aa11

2 files changed

Lines changed: 15 additions & 4 deletions

File tree

.github/workflows/continuous-integration-workflow.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,15 @@ jobs:
8282
env:
8383
NODE_OPTIONS: --max_old_space_size=16384
8484
if: runner.os == 'Linux'
85-
run: xvfb-run --server-args="-screen 0 1920x1080x24" npm run public-ui-test
85+
run: |
86+
# Patch vscode:prepublish to reinstall secretlint AFTER prune
87+
node -e "
88+
const fs = require('fs');
89+
const pkg = JSON.parse(fs.readFileSync('package.json'));
90+
pkg.scripts['vscode:prepublish'] += ' && npm install @secretlint/node';
91+
fs.writeFileSync('package.json', JSON.stringify(pkg, null, 2));
92+
"
93+
xvfb-run --server-args="-screen 0 1920x1080x24" npm run public-ui-test
8694
8795
- name: Build and run integration tests
8896
if: (success() || failure()) && runner.os == 'Linux'

test/ui/suite/componentCommands.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,13 @@ import * as fs from 'fs';
88
import * as pth from 'path';
99
import {
1010
ActivityBar,
11+
after,
12+
before,
1113
EditorView,
1214
SideBarView,
1315
TreeItem,
1416
ViewSection,
15-
after,
16-
before,
17+
Workbench,
1718
} from 'vscode-extension-tester';
1819
import { parse } from 'yaml';
1920
import { itemExists } from '../common/conditions';
@@ -33,6 +34,8 @@ export function testComponentCommands(path: string) {
3334
this.timeout(30_000);
3435
await new EditorView().closeAllEditors();
3536
view = await (await new ActivityBar().getViewControl(VIEWS.openshift)).openView();
37+
await (await new Workbench().openNotificationsCenter()).clearAllNotifications();
38+
3639
for (const item of [
3740
VIEWS.appExplorer,
3841
VIEWS.compRegistries,
@@ -42,7 +45,7 @@ export function testComponentCommands(path: string) {
4245
await (await view.getContent().getSection(item)).collapse();
4346
}
4447

45-
//expect component is running
48+
// expect component is running
4649
section = await view.getContent().getSection(VIEWS.components);
4750
try {
4851
await itemExists(`${componentName} (dev running)`, section);

0 commit comments

Comments
 (0)