Skip to content

Consume vscode-microprofile API #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

datho7561
Copy link
Contributor

See redhat-developer/vscode-microprofile#58

Consume the API provided by vscode-microprofile in order to wait for lsp4mp to start when running commands that interact with lsp4mp.

Closes #323

Signed-off-by: David Thompson davthomp@redhat.com

See redhat-developer/vscode-microprofile#58

Consume the API provided by vscode-microprofile in order to
wait for lsp4mp to start when running commands that interact with
lsp4mp.

Closes redhat-developer#323

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Copy link
Contributor Author

datho7561 commented Jun 29, 2021

@fbricon I implemented something close to the approach you suggested. vscode-microprofile would no longer depend on vscode-java, and would handle prompting to install it. vscode-microprofile exits its activate() method before lsp4mp is started, then has an API that lets you check once its started. vscode-quarkus still depends on vscode-microprofile, and uses the API to tell when it can use features of lsp4mp (detecting which projects are microprofile projects). This means a user can access the project generation wizard from rootless mode. However, vscode-java and jdt-ls still end up starting, since starting vscode-microprofile means starting lsp4mp, which means starting jdt.ls.

@datho7561
Copy link
Contributor Author

See comments on redhat-developer/vscode-microprofile#58

@datho7561 datho7561 closed this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate running Quarkus project generator without waiting for Java extension
1 participant