Skip to content

Commit fb8b95c

Browse files
Updated ann benchmark (#365)
* Updating local db spin steps * Updated ann benchmark
1 parent a287831 commit fb8b95c

File tree

5 files changed

+16
-16
lines changed

5 files changed

+16
-16
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.9.7"
3+
version = "0.9.9"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
66
readme = "README.md"

redisbench_admin/run_local/local_db.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,15 @@ def local_db_spin(
125125
r.ping()
126126
r.client_setname("redisbench-admin-stadalone")
127127
redis_conns.append(r)
128-
129-
for shardn, redis_process in enumerate(redis_processes):
130-
logging.info(
131-
"Checking if shard #{} process with pid={} is alive".format(
132-
shardn + 1, redis_process.pid
128+
if setup_type == "oss-cluster":
129+
for shardn, redis_process in enumerate(redis_processes):
130+
logging.info(
131+
"Checking if shard #{} process with pid={} is alive".format(
132+
shardn + 1, redis_process.pid
133+
)
133134
)
134-
)
135-
if is_process_alive(redis_process) is False:
136-
raise Exception("Redis process is not alive. Failing test.")
135+
if is_process_alive(redis_process) is False:
136+
raise Exception("Redis process is not alive. Failing test.")
137137

138138
if setup_type == "oss-cluster":
139139

redisbench_admin/utils/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def generate_common_server_args(
8585
"--bind",
8686
"{}".format(ip),
8787
"--save",
88-
"",
88+
"''",
8989
"--port",
9090
"{}".format(port),
9191
"--dir",

tests/test_local.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def test_generate_standalone_redis_server_args():
6565
"--bind",
6666
"127.0.0.1",
6767
"--save",
68-
"",
68+
"''",
6969
"--port",
7070
"9999",
7171
"--dir",
@@ -90,7 +90,7 @@ def test_generate_standalone_redis_server_args():
9090
"--bind",
9191
"127.0.0.1",
9292
"--save",
93-
"",
93+
"''",
9494
"--port",
9595
"9999",
9696
"--dir",
@@ -118,7 +118,7 @@ def test_generate_standalone_redis_server_args():
118118
"--bind",
119119
"127.0.0.1",
120120
"--save",
121-
"",
121+
"''",
122122
"--port",
123123
"1010",
124124
"--dir",
@@ -150,7 +150,7 @@ def test_generate_standalone_redis_server_args():
150150
"--bind",
151151
"127.0.0.1",
152152
"--save",
153-
"",
153+
"''",
154154
"--port",
155155
"1010",
156156
"--dir",
@@ -179,7 +179,7 @@ def test_generate_standalone_redis_server_args():
179179
"--bind",
180180
"127.0.0.1",
181181
"--save",
182-
"",
182+
"''",
183183
"--port",
184184
"9999",
185185
"--dir",

0 commit comments

Comments
 (0)