Unit Tests with TSCreateParams

[ascdi]

I am trying to verify that tsAdd was called with the correct TSCreateParams object.
But how can i compare one TSCreateParams to another?
All parameters are private, it has no equals implementation, nor any getters.

[sazzad16]

First of all, tsAdd with TSCreateParams is deprecated. tsAdd with TSAddParams is introduced.

Last but not least, you are welcome to craft a PR.

We have already merged PR(s) of equals and hashCode implementations. So that approach is likely to be accepted.

[sazzad16]

If i add an equals, will i break something?

No.

maybe the code relies on checks checking for pointer

No such stuff at this moment.

---

BTW, if you are considering to submit a PR, may I suggest to add equals and hashCode in more classes; i.e. at least all Params classes in timeseries package?

[ascdi]

Hi,

i can give it a try.
What branch shouldi branch off of?
There is no dev branch so i am a bit unsure

[sazzad16]

What branch shouldi branch off of?

Usually a PR should start based from master branch.
More guidelines here.

[ascdi]

Okay, i hope i did it :-D
#3959

[sazzad16]

@ascdi Thanks

[sazzad16]

Merged #3959