Skip to content

OpenTelemetry: disabled and inaccurate metrics #3229

@PavelPashov

Description

@PavelPashov

Description

Some OpenTelemetry metrics are still present in code even though they should not be exposed in their current form.

redis.client.csc.network_saved

Issue
This metric is still defined, but a correct implementation should measure payload avoided at the socket layer, which may require refactoring the client-side cache.

Possible fix
Refactor the client-side cache to track payload size so the metric can be implemented correctly.

db.client.connection.count

Issue
This metric is misleading because db.client.connection.state is always reported as used.

Possible fix
Rename the metric and convert it to an ObservableGauge.

db.client.connection.pending_requests

Issue
This metric is still defined, but should stay disabled until we settle on the right name and behavior.

Possible fix
Rename the metric, but keep it as an ObservableGauge, since changing it to an UpDownCounter would likely add unnecessary overhead.

Node.js Version

No response

Redis Server Version

No response

Node Redis Version

No response

Platform

No response

Logs

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions