fix: submit error issue

Author: AshishBarvaliya

d2h/overrides.py

@@ -14,22 +14,33 @@ def on_submit_purchase_receipt(doc, method):
             item_order.save()
 
 def validate_purchase_receipt(doc, method):
-    doc.custom_item_duplicate = []
-    for item in doc.items:
-        new_item = doc.append("custom_item_duplicate", {})
-        new_item.item_code = item.item_code
-        new_item.qty = item.qty
-        new_item.uom = item.uom
-        new_item.base_rate = item.base_rate
-        new_item.stock_uom = item.stock_uom
-        new_item.conversion_factor = item.conversion_factor
-        new_item.received_qty = item.received_qty
-        new_item.serial_no = item.serial_no
-        new_item.rejected_qty = item.rejected_qty
-        new_item.purchase_order = item.purchase_order
-        new_item.serial_and_batch_bundle = item.serial_and_batch_bundle
-        new_item.rejected_serial_and_batch_bundle = item.rejected_serial_and_batch_bundle
-        new_item.use_serial_batch_fields = item.use_serial_batch_fields
+    user_roles = frappe.get_roles(frappe.session.user)
+    if "Store Dept" in user_roles and "Administrator" not in user_roles:
+        for ind in range(len(doc.custom_item_duplicate)):
+            duplicate_item = doc.custom_item_duplicate[ind]
+            item = doc.items[ind]
+            if duplicate_item.item_code == item.item_code:
+                item.qty = duplicate_item.qty
+                item.serial_and_batch_bundle = duplicate_item.serial_and_batch_bundle
+                item.rejected_serial_and_batch_bundle = duplicate_item.rejected_serial_and_batch_bundle
+                item.use_serial_batch_fields = duplicate_item.use_serial_batch_fields
+    else:
+        doc.custom_item_duplicate = []
+        for item in doc.items:
+            new_item = doc.append("custom_item_duplicate", {})
+            new_item.item_code = item.item_code
+            new_item.qty = item.qty
+            new_item.uom = item.uom
+            new_item.base_rate = item.base_rate
+            new_item.stock_uom = item.stock_uom
+            new_item.conversion_factor = item.conversion_factor
+            new_item.received_qty = item.received_qty
+            new_item.serial_no = item.serial_no
+            new_item.rejected_qty = item.rejected_qty
+            new_item.purchase_order = item.purchase_order
+            new_item.serial_and_batch_bundle = item.serial_and_batch_bundle
+            new_item.rejected_serial_and_batch_bundle = item.rejected_serial_and_batch_bundle
+            new_item.use_serial_batch_fields = item.use_serial_batch_fields
 
 def on_delete_purchase_receipt(doc, method):
     on_submit_purchase_receipt(doc, method)

d2h/public/js/purchase_receipt.js

@@ -20,26 +20,4 @@ frappe.ui.form.on("Purchase Receipt", {
       frm.set_df_property("custom_section_break_fmgux", "hidden", false);
     }
   },
-  validate(frm) {
-    frm.doc.custom_item_duplicate = [];
-    frm.refresh_field("custom_item_duplicate");
-    frm.doc.items.map((item) => {
-      const new_item = frm.add_child("custom_item_duplicate");
-      new_item.item_code = item.item_code;
-      new_item.qty = item.qty;
-      new_item.uom = item.uom;
-      new_item.base_rate = item.base_rate;
-      new_item.stock_uom = item.stock_uom;
-      new_item.conversion_factor = item.conversion_factor;
-      new_item.received_qty = item.received_qty;
-      new_item.serial_no = item.serial_no;
-      new_item.rejected_qty = item.rejected_qty;
-      new_item.purchase_order = item.purchase_order;
-      new_item.serial_and_batch_bundle = item.serial_and_batch_bundle;
-      new_item.rejected_serial_and_batch_bundle =
-        item.rejected_serial_and_batch_bundle;
-      new_item.use_serial_batch_fields = item.use_serial_batch_fields;
-    });
-    frm.refresh_field("custom_item_duplicate");
-  },
 });