fix: delivery note store dept issue

Author: AshishBarvaliya

d2h/hooks.py

@@ -232,6 +232,9 @@
         "on_trash": "d2h.overrides.on_delete_purchase_receipt",
         "after_insert": "d2h.overrides.after_insert_purchase_receipt"
     },
+    "Delivery Note": {
+        "validate": "d2h.overrides.validate_delivery_note",
+    },
     "*": {
         "before_print": "d2h.api.before_print"
     }

d2h/overrides.py

@@ -88,6 +88,17 @@ def validate_purchase_receipt(doc, method):
             new_item.use_serial_batch_fields = item.use_serial_batch_fields
             new_item.original_quantity = item.original_quantity
 
+def validate_delivery_note(doc, method):
+    user_roles = frappe.get_roles(frappe.session.user)
+    if "Store Dept" in user_roles and "Administrator" not in user_roles:
+        for ind in range(len(doc.custom_delivery_note_item_duplicate)):
+            duplicate_item = doc.custom_delivery_note_item_duplicate[ind]
+            item = doc.items[ind]
+            if duplicate_item.item_code == item.item_code:
+                item.qty = duplicate_item.qty
+                item.serial_and_batch_bundle = duplicate_item.serial_and_batch_bundle
+                item.use_serial_batch_fields = duplicate_item.use_serial_batch_fields
+
 def on_delete_purchase_receipt(doc, method):
     on_submit_purchase_receipt(doc, method)
 

d2h/public/js/delivery_note.js

@@ -1,4 +1,24 @@
 frappe.ui.form.on("Delivery Note", {
+  refresh: function (frm) {
+    frm.fields_dict["custom_delivery_note_item_duplicate"].grid.wrapper.on(
+      "change",
+      'input[data-fieldname="qty"]',
+      function () {
+        roles = frappe.user_roles;
+        if (roles.includes("Store Dept") && !roles.includes("Administrator")) {
+          frm.doc.custom_item_duplicate.map((item) => {
+            frm.doc.items.map((new_item) => {
+              if (new_item.item_code == item.item_code) {
+                new_item.qty = item.qty;
+              }
+            });
+          });
+          frm.refresh_field("items");
+        }
+      }
+    );
+    update_duplicate_items(frm);
+  },
   onload: function (frm) {
     if (
       frappe.user_roles.includes("Store Dept") &&
@@ -17,44 +37,53 @@ frappe.ui.form.on("Delivery Note", {
       frm.set_df_property("total", "hidden", true);
       frm.set_df_property("custom_section_break_jwbcu", "hidden", false);
     }
+    frm.fields_dict["custom_delivery_note_item_duplicate"].grid.wrapper
+      .find(".grid-add-row")
+      .hide();
+    frm.fields_dict["custom_delivery_note_item_duplicate"].grid.wrapper
+      .find(".grid-remove-rows")
+      .hide();
+
+    frm.fields_dict[
+      "custom_delivery_note_item_duplicate"
+    ].grid.cannot_add_rows = true;
+    frm.fields_dict[
+      "custom_delivery_note_item_duplicate"
+    ].grid.only_sortable = false;
+
+    frm.fields_dict["custom_delivery_note_item_duplicate"].grid.refresh();
   },
   validate(frm) {
     if (
       frappe.user_roles.includes("Store Dept") &&
       !frappe.user_roles.includes("Administrator")
     ) {
-      frm.doc.items = [];
-      frm.refresh_field("items");
-      frm.doc.custom_delivery_note_item_duplicate.map((item) => {
-        const new_item = frm.add_child("items");
-        new_item.item_code = item.item_code;
-        new_item.item_name = item.item_code;
-        new_item.qty = item.qty;
-        new_item.uom = item.uom;
-        new_item.stock_uom = item.stock_uom;
-        new_item.conversion_factor = item.conversion_factor;
-        new_item.stock_qty = item.stock_qty;
-        new_item.serial_no = item.serial_no;
-        new_item.serial_and_batch_bundle = item.serial_and_batch_bundle;
-        new_item.use_serial_batch_fields = item.use_serial_batch_fields;
-      });
-      frm.refresh_field("items");
     } else {
-      frm.doc.custom_delivery_note_item_duplicate = [];
-      frm.refresh_field("custom_delivery_note_item_duplicate");
-      frm.doc.items.map((item) => {
-        const new_item = frm.add_child("custom_delivery_note_item_duplicate");
-        new_item.item_code = item.item_code;
-        new_item.qty = item.qty;
-        new_item.uom = item.uom;
-        new_item.stock_uom = item.stock_uom;
-        new_item.conversion_factor = item.conversion_factor;
-        new_item.stock_qty = item.stock_qty;
-        new_item.serial_no = item.serial_no;
-        new_item.serial_and_batch_bundle = item.serial_and_batch_bundle;
-        new_item.use_serial_batch_fields = item.use_serial_batch_fields;
-      });
-      frm.refresh_field("custom_delivery_note_item_duplicate");
+      update_duplicate_items(frm);
     }
   },
 });
+
+frappe.ui.form.on("Delivery Note Item", {
+  item_code: function (frm, cdt, cdn) {
+    update_duplicate_items(frm);
+  },
+});
+
+function update_duplicate_items(frm, row) {
+  frm.doc.custom_delivery_note_item_duplicate = [];
+  frm.refresh_field("custom_delivery_note_item_duplicate");
+  frm.doc.items.map((item) => {
+    const new_item = frm.add_child("custom_delivery_note_item_duplicate");
+    new_item.item_code = item.item_code;
+    new_item.qty = item.qty;
+    new_item.uom = item.uom;
+    new_item.stock_uom = item.stock_uom;
+    new_item.conversion_factor = item.conversion_factor;
+    new_item.stock_qty = item.stock_qty;
+    new_item.serial_no = item.serial_no;
+    new_item.serial_and_batch_bundle = item.serial_and_batch_bundle;
+    new_item.use_serial_batch_fields = item.use_serial_batch_fields;
+  });
+  frm.refresh_field("custom_delivery_note_item_duplicate");
+}