Skip to content

Restructure build config to fix RTKQ externals #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

markerikson
Copy link
Collaborator

This PR:

  • Reworks the tsup build config to restore listing @reduxjs/toolkit as an external for all of our nested entry points

Fixes #4983

Copy link

codesandbox bot commented May 14, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a92e5e:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit/react (modern.mjs) 28 B (-99.78% 🔽)
1. entry point: @reduxjs/toolkit/query (modern.mjs) 3.68 KB (-69.09% 🔽)
1. entry point: @reduxjs/toolkit/query/react (modern.mjs) 14.95 KB (-26.49% 🔽)
2. entry point: @reduxjs/toolkit/react (without dependencies) (modern.mjs) 28 B (-99.66% 🔽)
2. entry point: @reduxjs/toolkit/query (without dependencies) (modern.mjs) 110 B (-98.63% 🔽)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (modern.mjs) 56 B (-99.65% 🔽)
1. entry point: @reduxjs/toolkit/react (cjs, production.min.cjs) 14.38 KB (-0.19% 🔽)
1. entry point: @reduxjs/toolkit/query (cjs, production.min.cjs) 23.97 KB (+0.01% 🔺)
1. entry point: @reduxjs/toolkit/query/react (cjs, production.min.cjs) 26.42 KB (+0.93% 🔺)
2. entry point: @reduxjs/toolkit/react (without dependencies) (cjs, production.min.cjs) 509 B (-93.56% 🔽)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs, production.min.cjs) 10.72 KB (-38.28% 🔽)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs, production.min.cjs) 3.09 KB (-84.26% 🔽)
3. createDynamicMiddleware (react) (.modern.mjs) 948 B (-92.28% 🔽)
3. createApi (.modern.mjs) 15.35 KB (-26% 🔽)
3. createApi (react) (.modern.mjs) 17.4 KB (-23.44% 🔽)
3. fetchBaseQuery (.modern.mjs) 4.63 KB (-63.82% 🔽)

Copy link

netlify bot commented May 14, 2025

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 9a92e5e
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6824d9802d5280000863a06b
😎 Deploy Preview https://deploy-preview-4985--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markerikson markerikson merged commit 174eb83 into master May 14, 2025
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase in bundle size
1 participant