Skip to content

Conversation

andyfaff
Copy link
Collaborator

No description provided.

@andyfaff
Copy link
Collaborator Author

Updates made with gha-update package

@andyfaff andyfaff merged commit d47baf0 into reflectivity:master Nov 29, 2024
8 checks passed
@andyfaff andyfaff deleted the gha branch November 29, 2024 01:46

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a hash instead of a version tag?

@andyfaff
Copy link
Collaborator Author

The gha-update package does hashes by default. Using a script is nice because it does all actions automagically.
Also hashes are more secure. If the action author makes a point release then if you're using something like v4 then you automatically start using that. If there's a security problem with that point release you're exposing the repo to that. If the repo permissions aren't locked down then that can create issues. By contrast hashes are fixed to a single version.
Using an updater script every so often seems like a good balance.

@bmaranville
Copy link
Contributor

bmaranville commented Nov 29, 2024

Good points... I try to stick mostly to actions provided directly by GitHub (where one might worry less about hijacked version tags) but it's also nice to offload some maintenance to gha-update

@bmaranville
Copy link
Contributor

...though it seems like we're now trusting the gha-update package to not be malicious, instead

@andyfaff
Copy link
Collaborator Author

Sort of. You can check easily that youre not using a different action (unless there's a typosquat change). A single hash version is less likely to have a problem.

@andyfaff
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants