chore: properly depricate regolith-sway-audio-idle-inhibit #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilmer
reviewed
Nov 13, 2025
| wl-clipboard, | ||
| xwayland | ||
| Recommends: | ||
| sway-audio-idle-inhibit, |
Member
There was a problem hiding this comment.
So we need a changelog version sync to https://github.com/regolith-linux/SwayAudioIdleInhibit/blob/main/debian/changelog#L1. Not clear to me if we are using a gh action to bump changelog or manually pushing commits. Will check
Contributor
Author
There was a problem hiding this comment.
Even if we do have a action for that, even then I think the bumping needs to happen manually to ensure the major version gets updated, since this is technically a breaking change. Also the upstream version is also 2.0.0, so having 2.x as the version number should make a lot of sense.
Member
There was a problem hiding this comment.
Assuming no additional actions required here. Merging PR so I can make a release
kgilmer
deleted the
chore/break-replace-regolith-sway-audio-idle-inhibit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make sure updating to the latest
regolith-sessionpackage removes the deprecatedregolith-sway-audio-idle-inhibit, addedBreaksandReplacesdirectives. Also specified the minimum version ofsway-audio-idle-inhibitpackage required to ensure the systemd service is available.