use getSingletonHighlighter

[wolfv]

The getHighlighter function has been deprecated and leads to memory issues from what I read.

Closes #255

[changeset-bot]

🦋 Changeset detected

Latest commit: 275e38d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
rehype-pretty-code	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

npm i https://pkg.pr.new/rehype-pretty-code@250

npm i https://pkg.pr.new/@rehype-pretty/transformers@250

commit: 275e38d

[wolfv]

I am actually not sure if it makes a difference as you are already caching the highlighters. I am doing some testing on our frontend to see if it does change things.

[atomiks]

Yeah, the highlighter instances are already cached based on the theme key; not sure why the warning appears?

rehype-pretty-code/packages/core/src/index.ts

Lines 188 to 200 in eee1b21

	const key = JSON.stringify(theme);
	let cachedHighlighter = globalHighlighterCache.get(key);
	if (!cachedHighlighter) {
	cachedHighlighter = getHighlighter({
	themes:
	isJSONTheme(theme) || typeof theme === 'string'
	? [theme]
	: Object.values(theme),
	langs: ['plaintext'],
	});
	globalHighlighterCache.set(key, cachedHighlighter);
	}

Does the singleton work if you're creating instances with different theme keys in a single process?

[cmdcolin]

i think it was finally removed in shiki v3

[atomiks]

Oh does this PR already close #255?

[cmdcolin]

yep I believe so, the issue title refers to createHighlighter but this use of getSingletonHighlighter should fix it

[wolfv]

Thanks for merging! I think there is also upstream support for rehype now (https://shiki.matsu.io/packages/rehype)

[atomiks]

Yeah that's a good point! When this was first made in 2021, there wasn't any official options but now there's a good one. It doesn't have every feature I think, but it's probably better to try and contribute them to it instead

[marbemac]

Any idea when ya'll might cut a new release with this?

[atomiks]

@marbemac blocked on Shiki 3 upgrade, #257 - don't have time to work on it so any help would be great