Shiki 3

[atomiks]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 48d4db1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
rehype-pretty-code	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[cloudflare-workers-and-pages]

Deploying rehype-pretty-example-svelte with    Cloudflare Pages

Latest commit:	48d4db1
Status:	✅  Deploy successful!
Preview URL:	https://ff93f7e0.rehype-pretty-example-svelte.pages.dev
Branch Preview URL:	https://shiki-3.rehype-pretty-example-svelte.pages.dev

View logs

[pkg-pr-new]

npm i https://pkg.pr.new/rehype-pretty-code@257

npm i https://pkg.pr.new/@rehype-pretty/transformers@257

commit: 48d4db1

[cloudflare-workers-and-pages]

Deploying rehype-pretty-example-astro with    Cloudflare Pages

Latest commit:	48d4db1
Status:	✅  Deploy successful!
Preview URL:	https://c70a5f30.rehype-pretty-example-astro.pages.dev
Branch Preview URL:	https://shiki-3.rehype-pretty-example-astro.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying rehype-pretty-example-next with    Cloudflare Pages

Latest commit:	48d4db1
Status:	✅  Deploy successful!
Preview URL:	https://b01f0e99.rehype-pretty-example-next.pages.dev
Branch Preview URL:	https://shiki-3.rehype-pretty-example-next.pages.dev

View logs

[atomiks]

@o-az unfortunately there's a lot of Astro stuff failing I'm not well versed in, can you take a look?

[cloudflare-workers-and-pages]

Deploying rehype-pretty with    Cloudflare Pages

Latest commit:	48d4db1
Status:	✅  Deploy successful!
Preview URL:	https://4f8d078c.rehype-pretty.pages.dev
Branch Preview URL:	https://shiki-3.rehype-pretty.pages.dev

View logs

[sreeisalso]

When can we expect this in release? I'm actually exploring the source code, may I know how to test for astro?

[atomiks]

Hi @sreeisalso, I'm not sure either as I didn't add the Astro stuff myself. The other maintainer is currently busy, so any help would be great.

Here's what's failing: https://github.com/rehype-pretty/rehype-pretty-code/actions/runs/13405103328/job/37443486903?pr=257

The only difference in the actual core source code is changing to use the getSingletonHighlighter import. But the docs stuff is what's failing

[sreeisalso]

I did some research and found out that Astro is not properly supporting the shiki transformers look at -> shikijs/shiki#733

[ematipico]

Hi! That's funny, we are waiting for this land to support shikiji v3, but we can't do it without this library being compatible.

Let me check if I can do something to help.

[ematipico]

@atomiks

I believe the CI issue is caused by the fact that Astro still uses an old version of shikiji, but in this very PR you use v3 shikiji, which has different types compared to the ones that the current version (the one of docs) of Astro expects.

My suggestion is to limit the shikiji upgrade only to the package rehype-pretty-code, then wait for Astro to use shikiji v3, and update the docs website.

[atomiks]

@ematipico thanks, seem to finally have gotten it working

[ematipico]

Astro v5.5.3will support shiki v3