Skip to content

fix(client): don't break LaTeX when replacing carriage returns #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

remarkablemark
Copy link
Owner

What is the motivation for this pull request?

fix(client): don't break LaTeX when replacing carriage returns

Fixes #917

Related to remarkablemark/html-react-parser#1634

What is the current behavior?

All \r are removed from the HTML string, even if the raw string is formatted as \\r.

What is the new behavior?

\\r is no longer removed.

Checklist:

@remarkablemark remarkablemark self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (013e027) to head (d69bc66).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   92.90%   93.10%   +0.19%     
==========================================
  Files           7        7              
  Lines         141      145       +4     
  Branches       30       30              
==========================================
+ Hits          131      135       +4     
  Misses          8        8              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-dom-parser.min.js 2.11 KB (+3.41% 🔺) 43 ms (+3.41% 🔺) 139 ms (+707.93% 🔺) 181 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carriage return replacement breaking LaTeX
1 participant