fix: add missing ecs:TagResource permission for ECS tasks #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using serverless-step-functions to deploy ECS tasks with tags, the auto-generated IAM policies were missing the ecs:TagResource permission. This caused Step Functions executions to fail with an AccessDeniedException when attempting to tag ECS tasks. This commit adds the ecs:TagResource permission to the getEcsPermissions function, allowing ECS tasks to be properly tagged during execution. Fixes serverless-operations#656 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ecs:TagResourcepermission to auto-generated IAM policies for ECS tasksProblem
When using serverless-step-functions to deploy ECS tasks with tags, the auto-generated IAM policies were missing the
ecs:TagResourcepermission. This caused Step Functions executions to fail with anAccessDeniedExceptionwhen attempting to tag ECS tasks.Solution
Added
ecs:TagResourceto the list of permissions in thegetEcsPermissions()function inlib/deploy/stepFunctions/compileIamRole.js.Test plan
Fixes serverless-operations#656
🤖 Generated with Claude Code