Skip to content

Commit 8fb9cfc

Browse files
committed
fix minor a11y issues
1 parent b3b29cc commit 8fb9cfc

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

src/renderer/attribute/impl/style.cljs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
[_ k v {:keys [disabled]}]
1111
[:div.w-full.bg-primary.p-1
1212
[ui/cm-editor v {:on-blur #(rf/dispatch [::element.e/set-attr k %])
13+
:attrs {:id (name k)}
1314
:options {:mode "css"
1415
:readOnly disabled}}]])

src/renderer/timeline/views.cljs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,15 @@
3333
[editor-ref]
3434
(let [speed @(rf/subscribe [::timeline.s/speed])]
3535
[:div.inline-flex.items-center
36-
[:label.form-element "Speed"]
36+
[:label.form-element
37+
{:for "animation-speed"}
38+
"Speed"]
3739
[:> Select/Root
3840
{:value speed
3941
:onValueChange #(.setPlayRate (.-current editor-ref) %)}
4042
[:> Select/Trigger
4143
{:class "button px-2 overlay rounded-sm"
44+
:id "animation-speed"
4245
:aria-label "No a11y filter"}
4346
[:> Select/Value {:placeholder "Filter"}
4447
[:div.flex.gap-1.justify-between.items-center

src/renderer/ui.cljs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@
210210
(str (+ 4 off) "px"))))
211211

212212
(defn cm-editor
213-
[value {:keys [style options on-init on-blur]}]
213+
[value {:keys [attrs options on-init on-blur]}]
214214
(let [cm (ra/atom nil)
215215
ref (react/createRef)]
216216
(ra/create-class
@@ -237,9 +237,7 @@
237237

238238
:reagent-render
239239
(fn [value]
240-
[:textarea {:value value
241-
:style style
242-
:on-blur #()
243-
:on-change #()
244-
:ref ref
245-
:aria-label "Command prompt"}])})))
240+
[:textarea (merge {:value value
241+
:on-blur #()
242+
:on-change #()
243+
:ref ref} attrs)])})))

0 commit comments

Comments
 (0)