Skip to content

Commit 9e868ad

Browse files
committed
remove redundant event listeners
1 parent ec23c01 commit 9e868ad

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

src/renderer/frame/views.cljs

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,30 +10,23 @@
1010
[renderer.element.hierarchy :as element.hierarchy]
1111
[renderer.element.subs :as-alias element.subs]
1212
[renderer.element.views :as element.views]
13-
[renderer.event.impl.pointer :as event.impl.pointer]
1413
[renderer.event.impl.wheel :as event.impl.wheel]
1514
[renderer.frame.events :as-alias frame.events]
1615
[renderer.views :as views]))
1716

1817
(defn inner-component
19-
"We need access to the iframe's window to add the pointer move listener.
20-
This is required in order to track pointer movement outside of our canvas.
18+
"We need access to the iframe's window to add the wheel listener.
19+
This is required in order to prevent the default zoom behavior.
2120
https://github.com/ryanseddon/react-frame-component#accessing-the-iframes-window-and-document
2221
https://github.com/reagent-project/reagent/blob/master/doc/ReactFeatures.md#function-components"
2322
[]
2423
(let [frame-window (.-window (useFrame))]
2524
(reagent/create-class
2625
{:component-did-mount
27-
(fn []
28-
(.addEventListener frame-window "pointermove" event.impl.pointer/handler!)
29-
(.addEventListener frame-window "pointerup" event.impl.pointer/handler!)
30-
(.addEventListener frame-window "wheel" event.impl.wheel/handler! #js {:passive false}))
26+
#(.addEventListener frame-window "wheel" event.impl.wheel/handler! #js {:passive false})
3127

3228
:component-will-unmount
33-
(fn []
34-
(.removeEventListener frame-window "pointerup" event.impl.pointer/handler!)
35-
(.removeEventListener frame-window "pointermove" event.impl.pointer/handler!)
36-
(.removeEventListener frame-window "wheel" event.impl.wheel/handler!))
29+
#(.removeEventListener frame-window "wheel" event.impl.wheel/handler!)
3730

3831
:reagent-render #()})))
3932

@@ -78,7 +71,7 @@
7871
;; This is a different browsing context inside an iframe.
7972
;; We need to simulate the events to the parent window.
8073
on-keyboard-event (fn [e]
81-
;; TODO: use re-pressed :prevent-default-keys
74+
;; TODO: Use re-pressed :prevent-default-keys?
8275
(.preventDefault e)
8376
(.dispatchEvent js/window.parent.document
8477
(js/KeyboardEvent. (.-type e)

0 commit comments

Comments
 (0)