remove unused aliases and refactor

Author: sprocketc

.clj-kondo/config.edn

@@ -4,6 +4,7 @@
            :docstring-leading-trailing-whitespace {:level :warning}
            :used-underscored-binding {:level :warning}
            :unused-value {:level :warning}
+           :unused-alias {:level :warning}
            :redundant-call {:level :warning}
            :redundant-str-call {:level :warning}
            :clojure-lsp/unused-public-var {:exclude-regex #{"components.*"

src/renderer/app/db.cljs

@@ -85,7 +85,7 @@
 (def explain (m/explainer App))
 
 (def default
-  (m/decode App {:version config/version} malli.transform/default-value-transformer))
+  (m/decode App {:version config/version} m.transform/default-value-transformer))
 
 (def persisted-keys
   "Top level keys that should be persisted to local storage."

src/renderer/app/events.cljs

@@ -1,6 +1,5 @@
 (ns renderer.app.events
   (:require
-   [config :as config]
    [malli.error :as malli.error]
    [re-frame.core :as rf]
    [renderer.app.db :as app.db]
@@ -34,11 +33,9 @@
      (if (app.db/valid? app-db)
        {:db app-db}
        {::app.effects/local-storage-clear nil
-        :db (cond-> db
-              config/debug?
-              (notification.handlers/add (notification.views/spec-failed
-                                          "Invalid local configuration"
-                                          (-> app-db app.db/explain malli.error/humanize str))))}))))
+        :db (notification.handlers/add db (notification.views/spec-failed
+                                           "Invalid local configuration"
+                                           (-> app-db app.db/explain malli.error/humanize str)))}))))
 
 (rf/reg-event-db
  ::set-system-fonts

src/renderer/app/views.cljs

@@ -176,7 +176,7 @@
         [timeline.views/root]])
      [repl.views/root]]))
 
-(def paper-size
+(defonce paper-size
   {0 [2384 3370]
    1 [1684 2384]
    2 [1191 1684]

src/renderer/attribute/impl/href.cljs

@@ -9,7 +9,6 @@
    [renderer.attribute.views :as attribute.views]
    [renderer.element.events :as-alias element.events]
    [renderer.notification.events :as-alias notification.events]
-   [renderer.tool.events :as-alias tool.events]
    [renderer.tool.handlers :as tool.handlers]
    [renderer.tool.subs :as-alias tool.subs]
    [renderer.ui :as ui]))

src/renderer/attribute/impl/transform.cljs

@@ -1,8 +1,7 @@
 (ns renderer.attribute.impl.transform
   "https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/transform"
   (:require
-   [renderer.attribute.hierarchy :as attribute.hierarchy]
-   [renderer.element.events :as-alias element.events]))
+   [renderer.attribute.hierarchy :as attribute.hierarchy]))
 
 (defmethod attribute.hierarchy/description [:default :transform]
   []

src/renderer/core.cljs

@@ -31,7 +31,7 @@
    [renderer.ruler.subs]
    [renderer.snap.events]
    [renderer.snap.subs]
-   [renderer.theme.db :as db]
+   [renderer.theme.db :as theme.db]
    [renderer.theme.effects :as theme.fx]
    [renderer.theme.events :as theme.events]
    [renderer.theme.subs]
@@ -86,7 +86,7 @@
   (print "Type (help) to see a list of commands."))
 
 (defn ^:export init! []
-  (js/console.log (str "%c" easter-egg) (str "color: " renderer.theme.db/accent))
+  (js/console.log (str "%c" easter-egg) (str "color: " theme.db/accent))
 
   ;; https://code.thheller.com/blog/shadow-cljs/2017/10/14/bootstrap-support.html
   (bootstrap/init replumb.repl/st {:path "js/bootstrap" :load-on-init '[user]} bootstrap-cb!)

src/renderer/dialog/views.cljs

@@ -5,11 +5,9 @@
    [clojure.string :as string]
    [config :as config]
    [re-frame.core :as rf]
-   [renderer.app.subs :as-alias app.subs]
    [renderer.dialog.events :as-alias dialog.events]
    [renderer.dialog.subs :as-alias dialog.subs]
    [renderer.document.events :as-alias document.events]
-   [renderer.document.subs :as-alias document.subs]
    [renderer.menubar.views :as menubar.views]
    [renderer.ui :as ui]
    [renderer.utils.i18n :refer [t]]

src/renderer/document/db.cljs

@@ -41,4 +41,4 @@
 
 (def explain (m/explainer Document))
 
-(def default (m/decode Document {} malli.transform/default-value-transformer))
+(def default (m/decode Document {} m.transform/default-value-transformer))

src/renderer/document/events.cljs

@@ -7,7 +7,6 @@
    [renderer.app.db :refer [App]]
    [renderer.app.effects :as-alias app.effects]
    [renderer.app.events :refer [persist]]
-   [renderer.dialog.events :as-alias dialog.events]
    [renderer.dialog.handlers :as dialog.handlers]
    [renderer.dialog.views :as dialog.views]
    [renderer.document.db :as document.db]
@@ -82,7 +81,8 @@
  ::close
  [persist]
  (fn [db [_ id confirm?]]
-   (if (or (document.handlers/saved? db id) (not confirm?))
+   (if (or (document.handlers/saved? db id)
+           (not confirm?))
      (document.handlers/close db id)
      (-> db
          (document.handlers/set-active id)