enhance validation performance

Author: sprocketc

src/renderer/core.cljs

@@ -11,7 +11,6 @@
    [re-pressed.core :as rp]
    [reagent.dom :as ra.dom]
    [renderer.attribute.core]
-   [renderer.db]
    [renderer.dialog.events]
    [renderer.dialog.subs]
    [renderer.document.events :as document.e]

src/renderer/events.cljs

@@ -1,6 +1,5 @@
 (ns renderer.events
   (:require
-   [clojure.data :as data]
    [malli.core :as ma]
    [malli.error :as ma.error]
    [re-frame.core :as rf]
@@ -13,34 +12,18 @@
    [renderer.utils.local-storage :as local-storage]
    [renderer.utils.pointer :as pointer]))
 
-(def last-state (atom nil))
+(def valid? (ma/validator db/app))
 
 (defn check-and-throw
   "Throws an exception if `db` doesn't match the Spec"
-  [event schema state]
-  (when-not (ma/validate schema state)
+  [state event]
+  (when-not (valid? state)
     (js/console.error (str "Event: " (first event)))
-    (throw (js/Error. (str "Spec check failed: " (-> (ma/explain schema state)
+    (throw (js/Error. (str "Spec check failed: " (-> (ma/explain db/app state)
                                                      ma.error/humanize
                                                      str))))))
 
-(defn check-schema [schema state event]
-  (if @last-state
-    (let [[prev current _] (data/diff @last-state state)
-          changed-keys (set (concat (keys prev) (keys current)))]
-      (reset! last-state state)
-      (when (seq changed-keys)
-        (let [schema* (->> schema
-                           rest
-                           (filter (fn [[schema-key & _]] (changed-keys schema-key)))
-                           (cons :map)
-                           vec)]
-          (check-and-throw event schema* state))))
-    (do
-      (reset! last-state state)
-      (check-and-throw event schema state))))
-
-(def schema-valdator (rf/after (partial check-schema db/app)))
+(def schema-valdator (rf/after (partial check-and-throw)))
 
 (rf/reg-global-interceptor schema-valdator)
 

src/renderer/reepl/replumb.cljs

@@ -36,7 +36,7 @@
           #_(fn [& a] nil)
           fetch-file!)
          {:warning-as-error true
-          :verbose config/debug?
+          :verbose false ; config/debug?
           ;; :load-fn! (fn [z cb])
           :no-pr-str-on-value true}))
 cljs.js/*load-fn*