-
-
Notifications
You must be signed in to change notification settings - Fork 1
Font enhancements #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove font-scanner and simplify gh actions - build frame css and remove hardcoded values - enhance input font styles - add versions and env to preload - wip text->path for web - always use web apis to query local fonts
96823d2
to
2373abb
Compare
2373abb
to
f9c84a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.From.2025-06-07.12-45-24.mp4
This PR is mainly about allowing users to convert text elements to paths on web. This functionality was previously available on the electron app only. In order to do that, we use web APIs to get to the font data, and we also bundle a font with the app, to correctly convert text elements with the default font.
Resolves #79
The required changes also resulted in the following improvements
Noto Sans
is bundled with the app, so the UI is now consistent across all operating systemsfont-scanner
dependency that was causing build failures form time to time because of its native nature, was removedpreload
script is now just a thin proxy between main and renderertext->path
conversion is now using a dom-element to get the size/weight/style to improve the conversion accuracy