Add ability to replace/upsert in tables #11812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
timsaucer
force-pushed
the
tsaucer/replace-operation
branch
2 times, most recently
from
d77ed28 to
bf729fa
Compare
timsaucer
force-pushed
the
tsaucer/replace-operation
branch
from
bf729fa to
bfbe562
Compare
Member
Author
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/19371068817 |
timsaucer
added
exclude from changelog
timsaucer
changed the title
jleibs
approved these changes
Nov 15, 2025
jleibs
reviewed
Nov 15, 2025
| } | ||
| InsertOp::Replace => { | ||
| exec_err!("Invalid insert operation. Only append and overwrite are supported.")?; | ||
| let key_columns: Vec<_> = dataset |
Member
There was a problem hiding this comment.
If key_columns is empty and/or disjoint with reader.schema(), should we / do we get an error?
Member
Author
There was a problem hiding this comment.
Yes, you get the error A merge insert operation must specify at least one on key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Closes https://linear.app/rerun/project/add-ability-to-upsert-data-in-tables-aad5989947ac
What
This PR follows up on the work from #11694 and the issues linked inside it.
With this PR you can update existing tables if they have an index specified as a primary key. You do this by setting the metadata
rerun:is_table_indexon the field when creating the table. Duringupdateoperations we will use these columns as the keys by which we update the underlying lance table.