Open ReScript Core by default (#871)

Author: fhammerschmidt

rescript.json

@@ -11,7 +11,9 @@
   ],
   "uncurried": true,
   "ppx-flags": [],
-  "bsc-flags": [],
+  "bsc-flags": [
+    "-open RescriptCore"
+  ],
   "sources": [
     {
       "dir": "src",

src/Blog.res

@@ -14,7 +14,6 @@
  */
 
 module Link = Next.Link
-open RescriptCore
 
 let defaultPreviewImg = "/static/Art-3-rescript-launch.jpg"
 

src/BlogArticle.res

@@ -16,7 +16,6 @@
       builds are taking too long.  I think we will be fine for now.
   Link to NextJS discussion: https://github.com/zeit/next.js/discussions/11728#discussioncomment-3501
  */
-open RescriptCore
 
 let middleDotSpacer = " " ++ (String.fromCharCode(183) ++ " ")
 

src/Design.res

@@ -1,6 +1,6 @@
 // NOTE: This file will later be important to document our
 //       design tokens etc.
-open RescriptCore
+
 module ColorSquare = {
   @react.component
   let make = (~className="") => {

src/DocsOverview.res

@@ -1,4 +1,3 @@
-open RescriptCore
 module Card = {
   @react.component
   let make = (~title: string, ~hrefs: array<(string, string)>) => {

src/SyntaxLookup.res

@@ -55,9 +55,9 @@ module Status = {
 
   let compare = (a, b) =>
     switch (a, b) {
-    | (Deprecated, Deprecated) | (Active, Active) => 0
-    | (Active, Deprecated) => -1
-    | (Deprecated, Active) => 1
+    | (Deprecated, Deprecated) | (Active, Active) => Ordering.equal
+    | (Active, Deprecated) => Ordering.less
+    | (Deprecated, Active) => Ordering.greater
     }
 }
 
@@ -76,7 +76,7 @@ module Item = {
 
   let compare = (a, b) =>
     switch Status.compare(a.status, b.status) {
-    | 0 => String.compare(a.name, b.name)
+    | 0. => String.compare(a.name, b.name)
     | x => x
     }
 }
@@ -299,15 +299,15 @@ let default = (props: props) => {
       })
     })
     ->Js.Dict.entries
-    ->Belt.Array.reduce([], (acc, entry) => {
+    ->Array.reduce([], (acc, entry) => {
       let (title, items) = entry
-      if Js.Array.length(items) === 0 {
+      if Array.length(items) === 0 {
         acc
       } else {
         let children =
           items
-          ->Belt.SortArray.stableSortBy(Item.compare)
-          ->Belt.Array.map(item => {
+          ->Array.toSorted(Item.compare)
+          ->Array.map(item => {
             let onMouseDown = evt => {
               ReactEvent.Mouse.preventDefault(evt)
               onSearchValueChange(item.name)

src/bindings/RescriptCompilerApi.res

@@ -128,7 +128,7 @@ module LocMsg = {
     let result = Js.Dict.empty()
 
     for i in 0 to Js.Array.length(arr) - 1 {
-      let locMsg = Js.Array2.unsafe_get(arr, i)
+      let locMsg = Array.getUnsafe(arr, i)
       let id = makeId(locMsg)
 
       // The last element with the same id wins

src/common/Ansi.res

@@ -182,7 +182,7 @@ module Lexer = {
               switch x {
               | Some(result) =>
                 let groups = Js.Re.captures(result)
-                switch Js.Nullable.toOption(groups[1]) {
+                switch groups[1]->Option.flatMap(o => o->Js.Nullable.toOption) {
                 | Some(str) =>
                   switch Js.String2.split(str, ";") {
                   | ["0"] => ClearSgr({loc, raw})

src/common/BlogApi.res

@@ -76,9 +76,9 @@ let getAllPosts = () => {
     }
   })
 
-  Js.Array2.concat(nonArchivedPosts, archivedPosts)->Js.Array2.sortInPlaceWith((a, b) => {
+  Array.concat(nonArchivedPosts, archivedPosts)->Array.toSorted((a, b) =>
     String.compare(Node.Path.basename(b.path), Node.Path.basename(a.path))
-  })
+  )
 }
 
 let getLivePosts = () => {
@@ -97,9 +97,9 @@ let getLivePosts = () => {
     }
   })
 
-  livePosts->Js.Array2.sortInPlaceWith((a, b) => {
+  livePosts->Array.toSorted((a, b) =>
     String.compare(Node.Path.basename(b.path), Node.Path.basename(a.path))
-  })
+  )
 }
 
 let getArchivedPosts = () => {
@@ -119,9 +119,9 @@ let getArchivedPosts = () => {
     }
   })
 
-  archivedPosts->Js.Array2.sortInPlaceWith((a, b) => {
+  archivedPosts->Array.toSorted((a, b) =>
     String.compare(Node.Path.basename(b.path), Node.Path.basename(a.path))
-  })
+  )
 }
 
 module RssFeed = {
@@ -156,7 +156,7 @@ module RssFeed = {
   let getLatest = (~max=10, ~baseUrl="https://rescript-lang.org", ()): array<item> => {
     let items =
       getAllPosts()
-      ->Js.Array2.map(post => {
+      ->Array.map(post => {
         let fm = post.frontmatter
         let description = Js.Null.toOption(fm.description)->Belt.Option.getWithDefault("")
         {
@@ -166,7 +166,7 @@ module RssFeed = {
           pubDate: DateStr.toDate(fm.date),
         }
       })
-      ->Js.Array2.slice(~start=0, ~end_=max)
+      ->Array.slice(~start=0, ~end=max)
     items
   }
 

src/common/Url.res

@@ -64,8 +64,9 @@ let parse = (route: string): t => {
     (NoVersion, fullpath, [])
   } else {
     let version = switch fullpath[foundVersionIndex] {
-    | "latest" => Latest
-    | v => Version(v)
+    | Some("latest") => Latest
+    | Some(v) => Version(v)
+    | None => NoVersion
     }
     (
       version,