Const pointer for HexapodDamage

[dogoepp]

Very little importance detail here. Since we use a pointer for extra damage information, would it make sense to use a pointer to const, or even a const pointer to const ?

The code concerned is in hexapod_dart -> hexapod.hpp:

struct HexapodDamage {
        HexapodDamage() {}
        HexapodDamage(const std::string& type, const std::string& data, void* extra = nullptr) : type(type), data(data), extra(extra) {}

        std::string type;
        std::string data;
        void* extra = nullptr;
};

[jbmouret]

It would make sense to not use a void*...

-- JBM

On Thu, Jul 7, 2016 at 10:01 AM Dorian Goepp notifications@github.com
wrote:

Very little importance detail here. Since we use a pointer for extra
damage information, would it make sense to use a pointer to const, or even
a const pointer to const ?

The code concerned is in hexapod_dart -> hexapod.hpp
https://github.com/resibots/hexapod_simu/blob/master/hexapod_dart/include/hexapod_dart/hexapod.hpp
:

struct HexapodDamage {
HexapodDamage() {}
HexapodDamage(const std::string& type, const std::string& data, void* extra = nullptr) : type(type), data(data), extra(extra) {}

    std::string type;
    std::string data;
    void* extra = nullptr;

};

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#20, or mute the thread
https://github.com/notifications/unsubscribe/AFu8v84ckYyr2xUK0__mcl7LZvjWyng7ks5qTK_sgaJpZM4JG0tf
.

[costashatz]

It would make sense to not use a void*

But I want it to be able to add anything of any type.. I could make it a string and then parse it..