A client hang indefinitely if the server never reply

[avandecreme]

Here is a small example:

Server side:

public class DummyServerResource extends ServerResource {

    @Get
    public String retrieve() {
        System.exit(0);
        return "Dummy";
    }
}

Client side:

    public static void main(String[] args) throws IOException {
        Client client = new Client(Protocol.HTTP);
        ClientResource cr = new ClientResource("http://localhost:8182/resttest/dummy");
        cr.setNext(client);
        Representation get = cr.get();
        System.out.println(get.getText());
    }

Looking in the ConnectionController class, I found a possible explication for the issue. The selectKeys method has a sleepTime parameter which is never used.
If I use it as a parameter of the select method, it seems to fix the problem:

        int selectCount = getSelector().select(sleepTime);

But this line has been modified on purpose on July to reduce CPU consumption, so I guess it is not a valid fix.

[avandecreme]

Ok, it may be related to issue #659
I will try the suggested patch.

[jlouvel]

Nice, let me know if it helps!

[avandecreme]

Good news, that fixes the problem.

Here is my final client code:

    public static void main(String[] args) throws IOException {
        Context context = new Context();
        context.getParameters().add("controllerSleepTimeMs", "5000");
        context.getParameters().add("maxIoIdleTimeMs", "5000");
        Client client = new Client(context, Protocol.HTTP);
        ClientResource cr = new ClientResource("http://localhost:8182/resttest/dummy");
        cr.setNext(client);
        Representation get = cr.get();
        System.out.println(get.getText());
    }

I had to set both controllerSleepTimeMs and maxIoIdleTimeMs parameters to 5000 to get the client crash in 14 seconds.

One remark is that the documentation here: http://www.restlet.org/documentation/2.1/jse/engine/org/restlet/engine/connector/BaseHelper.html says that the default value for controllerSleepTimeMs is 1 whereas it is 60000.
I am not sure if it is the code or the doc who is wrong.

[jlouvel]

Thanks for the feedback. I'll fix the doc when applying the #659 patch as the sleep time changed from the previous value documented.

[jlouvel]

I've just fixed the documentation and applied the #659 patch.

[avandecreme]

Great.
I tried to use the maven SNAPSHOT from here: http://maven.restlet.org/org/restlet/jse/org.restlet/2.1-SNAPSHOT/ but it doesn't contain the update.
When are the snapshots published?