Add comprehrensive test to ensure integrity of all StateType mappings and getting corresponding WrappedBlockStates #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
booky10
requested changes
Mar 31, 2025
...main/java/com/github/retrooper/packetevents/protocol/world/states/defaulttags/BlockTags.java
Show resolved
Hide resolved
api/src/test/java/com/github/retrooper/packetevents/test/EnsureValidStateTypesTest.java
Outdated
Show resolved
Hide resolved
api/src/test/java/com/github/retrooper/packetevents/test/StateTypeMappingTest.java
Outdated
Show resolved
Hide resolved
...main/java/com/github/retrooper/packetevents/protocol/world/states/defaulttags/BlockTags.java
Show resolved
Hide resolved
Axionize
force-pushed
the
feat/comprehensive-statetype-integrity-testing
branch
from
6837f83 to
2ae5c15
Compare
Axionize
force-pushed
the
feat/comprehensive-statetype-integrity-testing
branch
from
2ae5c15 to
ff2d40d
Compare
|
Updated for 1.21.5 |
Axionize
force-pushed
the
feat/comprehensive-statetype-integrity-testing
branch
from
ff2d40d to
118dff1
Compare
|
@booky10 @retrooper is this going to be merged or should I close this? I've met all requested changes. |
Axionize
force-pushed
the
feat/comprehensive-statetype-integrity-testing
branch
from
118dff1 to
8fa768d
Compare
Axionize
force-pushed
the
feat/comprehensive-statetype-integrity-testing
branch
from
8fa768d to
cffc775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure something like what happened during the Registry rewrite never happens again